[FIXED] NRG: Don't mark current/healthy while catching up #6247
+143
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/healthz-during-catchup
branch
from
2e84f51 to
deb6765
Compare
wallyqs
changed the title
neilalexander
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're actively catching up, but
n.commit == n.applied, we would mark it as current/healthy. This would result in healthz reporting healthy too soon based on timing.Also removed the cancellation of catchup in
isCurrent. We shouldn't be able to influence catchup based on if and how often we call healthz. Also because we might need to do 2 catchups back-to-back if our first catchup takes longer and after that catchup is finished we get a heartbeat that re-triggers catchup. If we would cancel catchup due to the health check we would erroneously be marked healthy, whereas we require another catchup still.Signed-off-by: Maurice van Veen github@mauricevanveen.com