Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce outgoing pings #931

Closed
caspervonb opened this issue Apr 24, 2023 · 0 comments · Fixed by #932
Closed

Reduce outgoing pings #931

caspervonb opened this issue Apr 24, 2023 · 0 comments · Fixed by #932
Assignees
@caspervonb
Labels
enhancement Enhancement to existing functionality

Comments

@caspervonb
Copy link
Collaborator

Go client is quite stringent with its pings, we could be too.
Whenever we receive traffic, we could set an instant representing the last inbound message.
During the ping interval, we only send the ping if enough time has passed since last inbound message.
@caspervonb caspervonb added needs triage enhancement Enhancement to existing functionality and removed needs triage labels Apr 24, 2023
@caspervonb caspervonb self-assigned this Apr 24, 2023
This was referenced Apr 24, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caspervonb caspervonb

Labels
enhancement Enhancement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reset ping interval on incoming and outgoing messages caspervonb/nats.rs
1 participant
@caspervonb