Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/snack component #22

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Fix/snack component #22

merged 4 commits into from
Jul 25, 2023

Conversation

ophdlv
Copy link
Contributor

@ophdlv ophdlv commented Jun 30, 2023

The snack component has been removed from autogenerated client and recreated in components.

@ophdlv ophdlv marked this pull request as ready for review June 30, 2023 09:32
@georgemoon georgemoon self-requested a review July 25, 2023 13:19
georgemoon
georgemoon approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@georgemoon georgemoon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skim-read the code with Ophélie, seems ok.

@georgemoon georgemoon merged commit 5cec783 into naturalsolutions:dev Jul 25, 2023
@ophdlv ophdlv deleted the fix/snack-component branch July 26, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgemoon georgemoon georgemoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ophdlv @georgemoon