Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.idConverter not working #2808

Closed
netil opened this issue Aug 2, 2022 · 0 comments
Closed

data.idConverter not working #2808

netil opened this issue Aug 2, 2022 · 0 comments
Assignees
Labels

Comments

@netil
Copy link
Member

netil commented Aug 2, 2022

Description

When data.idConverter options is specified, and returning different id value than the original,
throws following error.

image

@netil netil added the bug label Aug 2, 2022
@netil netil self-assigned this Aug 2, 2022
netil added a commit to netil/billboard.js that referenced this issue Aug 3, 2022
Prevent data sorting with old id value

Ref naver#2808
@netil netil closed this as completed in 98f7103 Aug 3, 2022
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
# [3.6.0-next.1](3.5.1...3.6.0-next.1) (2022-09-15)

### Bug Fixes

* **area:** Fix unnecessary area element generation ([d43a1a7](d43a1a7)), closes [#2826](#2826)
* **axis:** fix undefined error reading generatedTicks ([4f3c101](4f3c101)), closes [#2786](#2786)
* **data:** Fix idConverter error ([98f7103](98f7103)), closes [#2808](#2808)
* **gauge:** Fix size mismatch w/o gauge multi label text is hidden ([6ee8a1e](6ee8a1e)), closes [#2799](#2799)
* **grid:** Remove grid.y.ticks default value ([4818e44](4818e44)), closes [#2809](#2809)
* **legend:** Add default for legend.contents.template ([55fbb02](55fbb02)), closes [#2780](#2780)
* **type:** Add missing polar module export ([a950abd](a950abd)), closes [#2833](#2833)
* **typescript:** update entry point in tsconfig ([ab4d98d](ab4d98d)), closes [#2855](#2855)
* **types:** Fix the type declarations for the y tick format ([1d378e0](1d378e0)), closes [#2790](#2790)

### Features

* **module:** Support dual CJS/ESM package ([437c007](437c007)), closes [#2202](#2202)
* **options:** Intent to ship data.groupsZeroAs ([3de8e7a](3de8e7a)), closes [#2813](#2813)
* **packages:** Intent to ship React wrapper ([4cef6ad](4cef6ad)), closes [#2838](#2838)
* **plugin:** Intent to ship TableView plugin ([215b611](215b611)), closes [#1873](#1873)
github-actions bot pushed a commit that referenced this issue Sep 29, 2022
# [3.6.0](3.5.1...3.6.0) (2022-09-29)

### Bug Fixes

* **area:** Fix unnecessary area element generation ([d43a1a7](d43a1a7)), closes [#2826](#2826)
* **axis:** fix undefined error reading generatedTicks ([4f3c101](4f3c101)), closes [#2786](#2786)
* **data:** Fix idConverter error ([98f7103](98f7103)), closes [#2808](#2808)
* **gauge:** Fix size mismatch w/o gauge multi label text is hidden ([6ee8a1e](6ee8a1e)), closes [#2799](#2799)
* **grid:** Remove grid.y.ticks default value ([4818e44](4818e44)), closes [#2809](#2809)
* **legend:** Add default for legend.contents.template ([55fbb02](55fbb02)), closes [#2780](#2780)
* **type:** Add missing polar module export ([a950abd](a950abd)), closes [#2833](#2833)
* **typescript:** update entry point in tsconfig ([ab4d98d](ab4d98d)), closes [#2855](#2855)
* **types:** Fix legend.item.tile.type literal type typo ([de9781f](de9781f))
* **types:** Fix the type declarations for the y tick format ([1d378e0](1d378e0)), closes [#2790](#2790)
* **types:** Fix the type declarations for the y tick format ([#2865](#2865)) ([2e38dee](2e38dee))

### Features

* **api:** Enhance .config() to return generation options ([455944e](455944e)), closes [#2864](#2864)
* **options:** Intent to ship bar.linearGradient ([3a9989f](3a9989f)), closes [#397](#397)
* **options:** Intent to ship bar.overlap ([046aedb](046aedb)), closes [#2839](#2839)
* **options:** Intent to ship data.groupsZeroAs ([3de8e7a](3de8e7a)), closes [#2813](#2813)
* **options:** Intent to ship legend.item.tile.type ([c379c9f](c379c9f)), closes [#2874](#2874)
* **packages:** Intent to ship React wrapper ([4cef6ad](4cef6ad)), closes [#2838](#2838)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant