Fail integration test when no jdk1.7 exists #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junoyoon
commented
Mar 5, 2023
| }.get().executablePath | ||
| } catch (e : Exception) { | ||
| logger.warn("The scavenger old agent should be built on JDK1.7. But it does not exist in this build") | ||
| "---" |
There was a problem hiding this comment.
Add no jdk1.7 exit signal with "---"
junoyoon
commented
Mar 5, 2023
| @@ -61,7 +62,7 @@ public static void beforeAll() { | |||
| assertNotNull("This test must be started from Gradle", codekvastAgentPath); | |||
| assertNotNull("This test must be started from Gradle", classpath); | |||
| assertNotNull("This test must be started from Gradle", javaPaths); | |||
|
|
|||
| assertFalse("This test must be tested with JDK1.7", javaPaths.contains("---")); | |||
There was a problem hiding this comment.
Fail the integration test with "---" property.
taeyeon-Kim
approved these changes
Mar 5, 2023
taeyeon-Kim
approved these changes
Mar 5, 2023
junoyoon
force-pushed
the
feature/fail-old-agent-integration-test-when-no-jdk1.7-exists
branch
from
0769a64
to
e739d93
Compare
junoyoon
force-pushed
the
feature/fail-old-agent-integration-test-when-no-jdk1.7-exists
branch
from
e739d93
to
68f3e0e
Compare
|
Use "" instead of "$version:---" |
junoyoon
deleted the
feature/fail-old-agent-integration-test-when-no-jdk1.7-exists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent scavenger project intellij import failure when the no JDK1.7 exists