test: modify Java test code #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hyeok7777
commented
Mar 7, 2023
hyeok7777
commented
- Fixed some variable names in file ConfigUtilsTest.java that do not conform to the Java naming convention
- Remove unnecessary public
taeyeon-Kim
force-pushed
the
feature/clean-up-test-code
branch
from
8e949b2
to
c0fcb2a
Compare
- Fixed some variable names that do not conform to the Java naming convention - Remove unnecessary public
hyeok7777
force-pushed
the
feature/clean-up-test-code
branch
from
c0fcb2a
to
4e58035
Compare
junoyoon
requested changes
Mar 8, 2023
|
@hyeok7777 please check my comment |
junoyoon
reviewed
Mar 10, 2023
| @@ -74,7 +74,7 @@ public void setProperties() { | |||
|
|
|||
| @Test | |||
| @DisplayName("it expands variables with braces") | |||
| public void expandVariables_with_braces() { | |||
| void expandVariablesWithBraces() { | |||
There was a problem hiding this comment.
Suggested change
| void expandVariablesWithBraces() { | |
| void expandVariables_with_braces() { |
|
@junoyoon |
kojandy
approved these changes
Mar 11, 2023
|
이번 건은 외부 fork 로 부터 PR 이라.. merge commit 이 들어왔습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.