feat: support deployment on Heroku #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethesque
force-pushed
the
feat/support-heroku
branch
4 times, most recently
from
a9c9f24
to
249b53c
Compare
This allows it to run on Heroku.
bethesque
force-pushed
the
feat/support-heroku
branch
from
249b53c
to
3cd7414
Compare
|
We've built and published from my fork to Heroku successfully, so if you'd prefer not to merge this now, that would be fine. Only merge it if you think it would provide value others. |
tommytroen
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
LGTM. @bethesque Thanks for the contribution, this might be useful for others. Will be merging now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to constrain the changes to the Dockerfile, but I couldn't work out how to do it using jibDockerBuild. I hope this is an acceptable solution.