-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use ktor 2.0.1 #250
Conversation
plz run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello. Jawk
Tests runs fine locally.
But i get som deprecation notice:
mock-oauth2-server/src/test/kotlin/examples/kotlin/ktor/resourceserver/OAuth2ResourceServerAppTest.kt: (18, 13):
withTestApplication(Application.() -> Unit, TestApplicationEngine.() -> R):
R' is deprecated. Please use new `testApplication` API: https://ktor.io/docs/migrating-2.html#testing-api
also (35, 13) and (55, 13)
Yes, The withTestApplication/withApplication functions are replaced with a new testApplication function. Should we include the change in this PR or in a new one? |
I recon it could be included in this PR, as it is spinns of after the update to ktor 2.0.1. |
@ybelMekk i fixed the usage of withTestApplication due to deprecation, can you run the tests now, and see if its all good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests run 🆗
@MikAoJk did you run formatKotlin
?
no i will do |
My local issue was due to this content in the /etc/hosts file: i need to remove the view-localhost and the the tests worked |
@ybelMekk formatKotlin done |
@tommytroen 👀? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. 🚢
No description provided.