Remove unnecessary errors override

navikt · Dec 5, 2024 · 5c1e9a9 · 5c1e9a9
1 parent 072b34b
commit 5c1e9a9
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 18 deletions.
diff --git a/packages/shared-components/src/formio/components/core/activities/Activities.tsx b/packages/shared-components/src/formio/components/core/activities/Activities.tsx
@@ -35,10 +35,6 @@ class Activities extends BaseComponent {
     return activitiesBuilder();
   }
 
-  override get errors() {
-    return this.componentErrors;
-  }
-
   override getError(): string | undefined {
     const error = this.componentErrors[0];
     if (error) return error.message;

diff --git a/packages/shared-components/src/formio/components/core/address/Address.tsx b/packages/shared-components/src/formio/components/core/address/Address.tsx
@@ -126,11 +126,11 @@ class Address extends BaseComponent {
   }
 
   getReadOnly(): boolean {
-    return !!this.component?.prefillKey && this.isSubmissionDigital();
+    return this.hasPrefill() || super.getReadOnly();
   }
 
   showAddressTypeChoice(): boolean {
-    return this.hasPrefill() || super.getReadOnly();
+    return !!this.component?.prefillKey && this.isSubmissionPaper();
   }
 
   setValue(value: any) {

diff --git a/packages/shared-components/src/formio/components/core/monthpicker/MonthPicker.tsx b/packages/shared-components/src/formio/components/core/monthpicker/MonthPicker.tsx
@@ -32,10 +32,6 @@ class MonthPicker extends BaseComponent {
     this.rerender();
   }
 
-  override get errors() {
-    return this.componentErrors;
-  }
-
   override checkValidity(data?: SubmissionData, dirty?: boolean, row?: SubmissionData): boolean {
     this.removeAllErrors();
 

diff --git a/...shared-components/src/formio/components/extensions/address-validitity/AddressValidity.tsx b/...shared-components/src/formio/components/extensions/address-validitity/AddressValidity.tsx
@@ -26,10 +26,6 @@ export default class AddressValidity extends BaseComponent {
     return addressValidityBuilder();
   }
 
-  get errors() {
-    return this.componentErrors;
-  }
-
   checkValidity(data, dirty, row) {
     this.removeAllErrors();
 

diff --git a/packages/shared-components/src/formio/components/extensions/identity/Identity.tsx b/packages/shared-components/src/formio/components/extensions/identity/Identity.tsx
@@ -53,10 +53,6 @@ export default class Identity extends BaseComponent {
     return this.hasPrefill() || super.getReadOnly();
   }
 
-  get errors() {
-    return this.componentErrors;
-  }
-
   checkValidity(data, dirty, row) {
     this.removeAllErrors();