Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release #253

Merged
merged 2 commits into from
Oct 25, 2023
Merged

chore: release #253

merged 2 commits into from
Oct 25, 2023

Conversation

frol
Copy link
Collaborator

@frol frol commented Oct 24, 2023 •
edited by dj8yfo
Loading

🤖 New release

  • borsh: 1.1.0 -> 1.1.1 (✓ API compatible changes)
  • borsh-derive: 1.1.0 -> 1.1.1
Changelog

borsh

1.1.1 - 2023-10-25

Other

  • add test_schema_conflicts (#254)
  • addressed warnings in docs generation (#252)
  • simplify discriminants handling in schema derives (#241)

This PR was generated with release-plz.

@frol frol requested a review from dj8yfo as a code owner October 24, 2023 20:15
@frol frol force-pushed the release-plz/2023-10-24T20-15-14Z branch from 3a4ba4e to 7c13f36 Compare October 25, 2023 11:47
@frol
Copy link
Collaborator Author

frol commented Oct 25, 2023

Since the breaking change is under unstable__schema feature, it should not be 2.0 release, so we will need to update this release manually before merging this PR.

@frol frol marked this pull request as draft October 25, 2023 20:16
@frol
chore: release
d9ad9b0 
Signed-off-by: Vlad Frolov <304265+frol@users.noreply.github.com>
@frol frol force-pushed the release-plz/2023-10-24T20-15-14Z branch from 7c13f36 to d9ad9b0 Compare October 25, 2023 20:52
@dj8yfo
Copy link
Collaborator

dj8yfo commented Oct 25, 2023

Since the breaking change is under unstable__schema feature, it should not be 2.0 release, so we will need to update this release manually before merging this PR.

there was no breaking change, this was due to exclamation mark chore! pop!ping up in master commit message somewhat unexpectedly.

@dj8yfo dj8yfo marked this pull request as ready for review October 25, 2023 21:15
@frol frol merged commit 73f7d7f into master Oct 25, 2023
7 checks passed
@frol frol deleted the release-plz/2023-10-24T20-15-14Z branch October 25, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dj8yfo dj8yfo dj8yfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frol @dj8yfo