Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about unrecognized fields in config.json #9073

Open
nikurt opened this issue May 17, 2023 · 0 comments
Open

Warn about unrecognized fields in config.json #9073

nikurt opened this issue May 17, 2023 · 0 comments
Labels
Node Node team T-node Team: issues relevant to the node experience team

Comments

@nikurt
Copy link
Contributor

nikurt commented May 17, 2023

We already use serde_ignored to detect unrecognized fields, but there is a catch.
It only notifies about unrecognized fields in sub-fields of Config.
Because field Config::gc has a serde attribute flatten, that crate fails to detect unrecognized fields in Config itself, only detects unrecognized fields in its sub-fields.

The issue is known in serde_ignored but wasn't fixed for more than a year:
dtolnay/serde-ignored#10

@nikurt nikurt added the T-node Team: issues relevant to the node experience team label May 17, 2023
@gmilescu gmilescu added the Node Node team label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Node Node team T-node Team: issues relevant to the node experience team
Projects
None yet
Development

No branches or pull requests

2 participants