Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nonsense transaction protobuf serde issue with send money #531

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

azban
Copy link
Contributor

@azban azban commented Feb 7, 2019

No description provided.

@azban
Copy link
Contributor Author

azban commented Feb 7, 2019

the issue arose because we weren't actually making good assertions in test_rpc_cli. in this case, we were just checking that you could submit a transaction. to properly test this, we will need to create an account, send money to the account and then view the account to check the balance.

@nearmax, have you been thinking about fixtures for integration testing? i'm inclined to set up everything explicitly in each test, and then extract out later, but at some point it would be good if we had a fixtures framework (chainspec would be useful for this use case), so that we could test sending money in isolation, without having to go through the motions of creating accounts (for the sake of efficiency and complexity)

@MaksymZavershynskyi
Copy link
Contributor

Yes, I have investigated fixtures and parametrized tests in rust, and I have a complete understanding of how we can do it in a nice way. However, I did not have time implementing it. We can discuss it whenever you have time.

Copy link
Contributor

@MaksymZavershynskyi MaksymZavershynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for now, but we should brush up our integration tests later, as discussed.

@azban azban force-pushed the hotfix-send-money-proto-serde branch from 2425811 to baf60a6 Compare February 7, 2019 21:38
@azban azban merged commit 873ba8f into master Feb 7, 2019
@azban azban deleted the hotfix-send-money-proto-serde branch February 7, 2019 21:41
@ilblackdragon ilblackdragon added this to the AlphaNet milestone Mar 28, 2019
near-bulldozer bot pushed a commit that referenced this pull request Nov 24, 2021
Let's remove usage of `lazy_static!` in runtime.

Part of #531
pmnoxx added a commit that referenced this pull request Nov 25, 2021
Let's remove usage of `lazy_static!` in runtime.

Part of #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants