fix: flaky prefetcher tests #8255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefetcher tests have become flaky in CI lately, failing with `"unexpected number of prefetched values"`. I was not able to reproduce it locally. But there is a timeout that is at least one source for flakyness. This commit removes this source by properly waiting on the background threads to finish instead of relying on a timeout. Hopefully resolves near#8252. (Will have to reopen if not.)
pugachAG
reviewed
Dec 20, 2022
pugachAG
approved these changes
Dec 20, 2022
akhi3030
reviewed
Dec 21, 2022
| // causes all background threads to stop after they finish the current | ||
| // work. It will even join them and wait until all threads are done. | ||
| // | ||
| // Because threads are joined, there is also a possibility this will |
There was a problem hiding this comment.
nit: is it worth clarifying what this refers to here? Maybe replace it with drop(tries)?
There was a problem hiding this comment.
Yes makes sense, updated now.
|
This needs a code owner approval before I can merge it. @Longarithm or @akhi3030 maybe? |
akhi3030
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefetcher tests have become flaky in CI lately, failing with
"unexpected number of prefetched values".I was not able to reproduce it locally. But there is a timeout that
is at least one source for flakyness. This commit removes this
source by properly waiting on the background threads to finish
instead of relying on a timeout.
Hopefully resolves #8252. (Will have to reopen if not.)