Code Quality Updates - Part 2 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jbouder
commented
Apr 15, 2024
| @@ -12,7 +12,7 @@ | |||
| "lint": "eslint src --ext ts,tsx --report-unused-disable-directives --max-warnings 0", | |||
| "preview": "vite preview", | |||
| "format": "npx prettier src --write", | |||
| "test": "NODE_ENV=development jest", | |||
There was a problem hiding this comment.
This was something we unnecessarily added when implementing the dummy axios data, to support testing in vercel. It actually is not needed, and is resulting in a lot of unnecessary errors to be logged when running unit tests.
jbouder
commented
Apr 15, 2024
| @@ -30,7 +30,6 @@ describe('AppCard', () => { | |||
| username="Developer" | |||
| framework="Some Framework" | |||
| url="/some-url" | |||
| ready={true} | |||
There was a problem hiding this comment.
This is no longer used in the card, removing
jbouder
commented
Apr 15, 2024
Comment on lines
-213
to
-215
| {error ? ( | ||
| <div>An error occurred: {(error as Error).message}</div> | ||
| ) : isLoading ? ( |
There was a problem hiding this comment.
Removed and replaced with current pattern or displaying overall errors at app level
kildre
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
N/A
What does this implement/fix?
Put a
xin the boxes that applyTesting
Any other comments?