Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index.css button-menu color overriding behavior #428

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Aug 1, 2024

Reference Issues or PRs

closes #427

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 5:20pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 5:20pm

@viniciusdc
Copy link
Contributor Author

due to my extensions in my editor, it also expanded the CSS config in a more readable way, let me know if that needs to be restore to original.

@krassowski
Copy link
Member

I think this file is not meant to be edited by hand. While many projects use compilation at release time, this one appears to be committing compiled static assets to git repo. In that case the change likely needs to be done elsewhere and the static assets need to be recompiled. I guess this is why my PR #355 was not merged for over a month? I now force-pushed with static assets recompiled.

@jbouder
Copy link
Collaborator

jbouder commented Aug 1, 2024

I believe you're going to want to make your change here:

color: #0F1015 !important;
.

Then you'll need to do an npm run build from the ui directory and commit all changes

@viniciusdc
Copy link
Contributor Author

I believe you're going to want to make your change here:

color: #0F1015 !important;

.
Then you'll need to do an npm run build from the ui directory and commit all changes

Nice, thanks @jbouder -- It was already late, so I didn't even noticed that file was an artifact of the build process XD, thanks for pointing out the right one

@viniciusdc
Copy link
Contributor Author

@jbouder @aktech this is now correctly addressed thanks, ready for another look

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and works based on a quick test.

@viniciusdc
Copy link
Contributor Author

@aktech may we get this merged and a new release cut? this is a blocker on Nebari 2024.7.1 using the latest jhub-apps

@jbouder jbouder merged commit b02c937 into main Aug 1, 2024
25 checks passed
@jbouder jbouder deleted the 427-button-menu-order branch August 1, 2024 23:19
@jbouder
Copy link
Collaborator

jbouder commented Aug 1, 2024

@aktech may we get this merged and a new release cut? this is a blocker on Nebari 2024.7.1 using the latest jhub-apps

@aktech , you’re up

@aktech
Copy link
Member

aktech commented Aug 1, 2024

I'll do another release, thanks for getting this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Navbar theme text color not being respected
4 participants