Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-longer needed inclusion of xsrf token #45

Closed
wants to merge 3 commits into from

Conversation

krassowski
Copy link
Member

This is no longer needed because the token is now included; in fact the inclusion now prevents the second instance from accepting the request.

Reference Issues or PRs

Follow-up to #44

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

This is no longer needed because the token is now included;
in fact the inclusion now prevents the second instance from accepting
the request.
@krassowski krassowski added the bug label Jul 28, 2024
Copy link

Binder 👈 Launch a Binder on branch nebari-dev/jupyterlab-gallery/remove-no-longer-needed-xsrf

@krassowski
Copy link
Member Author

This does not work - the GET succeeds but POST fails; it appears auth token is only checked later? Or only for GET/HEAD/OPTIONS.

@krassowski krassowski closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant