Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Add --dry-run option to qhub installation #1368

Closed
viniciusdc opened this issue Jul 12, 2022 · 3 comments
Closed

[ENH] - Add --dry-run option to qhub installation #1368

viniciusdc opened this issue Jul 12, 2022 · 3 comments
Labels
area:developer-experience 👩🏻‍💻 Close? Issues which may be closable unless discussion continued type: duplicate 👯‍♀️ This issue or PR already exists type: enhancement 💅🏼 New feature or request

Comments

@viniciusdc
Copy link
Contributor

viniciusdc commented Jul 12, 2022

Feature description

The Terraform Provision and Terraform Apply steps in the qhub deploy could be executed as a dry run, just like running the terraform plan command.

The dry run would refresh the state file (if present) and generate a deployment plan based on the provided qhub infrastructure but not apply the plan.

Value and/or benefit

The benefits of doing so would be:

  • Generating the qhub full infrastructure model and exporting/importing it to proper locations if needed -- infra cost might be able to use this for better predictions
  • CI testing, we could then mimic the installation process and run these (without deploying an instance) into different architectures, like Windows, Linux, and macOS. This would help cathing situations such as [ENH] - Add support for M1 Macs #1367
  • We would also be able to inspect the outputted plan and compare it with a pre-defined test template to assert versions, providers, and config maps are all well-defined and present.

Anything else?

#93 initially proposed this

@trallard
Copy link
Member

trallard commented Dec 6, 2022

There is a dry-run flag now in the CLI, is this issue still relevant? it seems it is now not applicable cc @viniciusdc and @iameskild

see

"--dry-run",

@trallard trallard added the Close? Issues which may be closable unless discussion continued label Dec 6, 2022
@iameskild
Copy link
Member

Hi @trallard, the dry-run flag above is for the nebari render, I believe there is interest in adding a dry-run flag for nebari deploy / nebari destroy.

Here is another issue was recently opened requesting something very similar: #1538. As I outlined in that issue, this can be a bit tricky given that we are deploying Terraform in stages.

@trallard
Copy link
Member

trallard commented Dec 8, 2022

ok since the other issue has more information I am going to close this as a duplicate and carry on with the discussion there

@trallard trallard added the type: duplicate 👯‍♀️ This issue or PR already exists label Dec 8, 2022
@trallard trallard closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:developer-experience 👩🏻‍💻 Close? Issues which may be closable unless discussion continued type: duplicate 👯‍♀️ This issue or PR already exists type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants