Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable file typo checking in typos #2598

Open
Adam-D-Lewis opened this issue Jul 30, 2024 · 1 comment · May be fixed by #2731
Open

Enable file typo checking in typos #2598

Adam-D-Lewis opened this issue Jul 30, 2024 · 1 comment · May be fixed by #2731
Labels
good first issue Good for newcomers

Comments

@Adam-D-Lewis
Copy link
Member

Context

In #2568 I set default.check-filename = false. We should enable it. This will then rename src/_nebari/stages/kubernetes_services/template/modules/kubernetes/services/dask-gateway/controler.tf (missing l in controler.tf) to src/_nebari/stages/kubernetes_services/template/modules/kubernetes/services/dask-gateway/controller.tf. We need to make sure we delete the extra file in a Nebari upgrade (or test and make sure the file would be deleted in an upgrade and not left around inappropriately).

Value and/or benefit

Fix typo.

Anything else?

No response
@Adam-D-Lewis Adam-D-Lewis added needs: triage 🚦 Someone needs to have a look at this issue and triage good first issue Good for newcomers and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Jul 30, 2024
@blakerosenthal
Copy link
Contributor

@Adam-D-Lewis I've verified that running nebari deploy after fixing the typo and running nebari upgrade does not delete the old controler.tf file. Can you point me to the right place in the codebase where that cleanup needs to happen?

@blakerosenthal blakerosenthal linked a pull request Sep 20, 2024 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
🪴 Nebari Project Management
Status: New 🚦
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Precommit typos blakerosenthal/nebari
2 participants
@blakerosenthal @Adam-D-Lewis