Nebari cli: Add files _init.py and main.py #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
type: enhancement 💅🏼
iameskild
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Thanks for this @asmijafar20 :)
We'll need to write callback functions for many of the options (see _init.py:check_cloud_provider_creds) but we can do that in a later PR.
Feel free to open new PRs again this same branch (typer_cli) as often you have new code to contribute. I'll make sure to review them within 24 hours!
cc @trallard
viniciusdc
added a commit
that referenced
this pull request
Oct 7, 2022
* Initial typer CLI implmentation * edit logic * Nebari cli: Add files _init.py and main.py (#1423) * Nebari cli: Add files _init.py and main.py * run pre-commit Co-authored-by: iameskild <eskild@doublee.io> * Order CLI commands * Nebari typer cli commands (#1432) * Nebari typer cli commands * add validate command * Change validate command * add precommit * Nebari Render Command (#1433) * Nebari Render Command * add render_template * Add dry-run * Updates to init * More work on init * Nebari deploy and destroy commands (#1436) * Nebari deploy and destroy commands * Add typer confirm to destroy command * Run pre-commit Co-authored-by: eskild <42120229+iameskild@users.noreply.github.com> Co-authored-by: iameskild <eskild@doublee.io> * Add guided-init * Add deploy flags and change repository default value (#1441) * Nebari deploy and destroy commands * Add typer confirm to destroy command * Add deploy arguments and change repository default value * Add rendre design * Run pre-commit Co-authored-by: eskild <42120229+iameskild@users.noreply.github.com> Co-authored-by: iameskild <eskild@doublee.io> * Nebari Typer CLI * Add pre-commit * Add disable_checks in deploy command * Combine guided-init and init, part 1 * Remove `dotenv` work. (#1472) * Remove Usage: dotenv [OPTIONS] COMMAND [ARGS] * Remove pathlib * guided-init clean up * Added `support`, `cost`, `upgrade` and `keycloak` commands. (#1468) * Add , , and commands. * Add pre-commit * Add pre-commit * Add pre-commit * Add rich print * Change do_keycloak function * Create two keycloak subcommands Co-authored-by: iameskild <eskild@doublee.io> Co-authored-by: eskild <42120229+iameskild@users.noreply.github.com> * clean up * update help messages * Update qhub/cli/_init.py Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com> * Update qhub/cli/_init.py Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com> * Changes from review, part 1 * Update qhub/cli/_init.py Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com> * Update qhub/cli/_init.py Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com> * Update qhub/cli/_init.py Co-authored-by: Tania Allard <taniar.allard@gmail.com> * Update qhub/cli/_init.py Co-authored-by: Tania Allard <taniar.allard@gmail.com> * Update qhub/cli/_init.py Co-authored-by: Tania Allard <taniar.allard@gmail.com> * Update qhub/cli/_init.py Co-authored-by: Tania Allard <taniar.allard@gmail.com> * Update qhub/cli/_init.py Co-authored-by: Tania Allard <taniar.allard@gmail.com> * Update qhub/cli/main.py Co-authored-by: Tania Allard <taniar.allard@gmail.com> * Changes from review, part 2 * Update env, clean up * Changes from review, part 3 * Minor update * Changes based review, part 4 * more clean up * Add `version` options to Nebari CLI (#1476) * Add version Options to Nebari * Add pre-commit Co-authored-by: eskild <42120229+iameskild@users.noreply.github.com> * Change colour from blue1 to green and spring_green to blue * Add suggested changes, Remove extra spaces * Add pre-commit * change kubernetes msg * Update CI to use new nebari cli entrypoint (#1480) * Update CI to use new nebari cli entrypoint * Add --disable-prompt to nebari init * Update name of keycloak subcommands * Reorder command * Update command * Minor update to test_e2e * Update hostname used for test_deployment * Another minor update to the tests_e2e * Add --disable-prompt to nebari destroy * use --disable-prompt in ci test * Update .github/workflows/kubernetes_test.yaml Co-authored-by: Vinicius D. Cerutti <51954708+viniciusdc@users.noreply.github.com> * Update kubernetes_test.yaml * Update .github/workflows/kubernetes_test.yaml Co-authored-by: Tania Allard <taniar.allard@gmail.com> * Update qhub/cli/main.py Co-authored-by: Tania Allard <taniar.allard@gmail.com> * Fix yaml * Fix yaml again Co-authored-by: Vinicius D. Cerutti <51954708+viniciusdc@users.noreply.github.com> Co-authored-by: Tania Allard <taniar.allard@gmail.com> Co-authored-by: iameskild <eskild@doublee.io> Co-authored-by: eskild <42120229+iameskild@users.noreply.github.com> Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com> Co-authored-by: Tania Allard <taniar.allard@gmail.com> Co-authored-by: Vinicius D. Cerutti <51954708+viniciusdc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Changes introduced in this PR:
Types of changes
What types of changes does your PR introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Documentation
Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.