Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH 2451: skip conditionals #2561

Closed

Conversation

BrianCashProf
Copy link
Contributor

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

This PR is related to the issue stated in ENH #2451: #2451

I have added a job to the integration test related github actions. This job acts as a mediary for a boolean environment variable and a conditional statement added to integration test job at it's top level. This was made so that a user with a fork of nebari who do not have access to the credentials for the cloud resources the job needs.

This method was chosen for the following reasons:

  • In testing, booleans on the step level did not prevent a failing of attempting to access the credentials.
  • In testing, environment variables could not be used to do a boolean on the job at large.
  • A flag that was not branch specific was requested by a few users (not stated in ticket) and this solution could provide this.
  • This avoids adding "push:" statements to the YAML (as opposed to using ignore-branches) which will keep the workflow inherently manual or on a cron job as dictated thus far.

Added a boolean environment variable which enables or disables running the aws integration tests.
Adds boolean environment variable so that user can toggle off the Azure integration test.
adds boolean environment variable so that user can toggle off the Digital Ocean integration test.
Adds boolean environment variable so that user can toggle off the GCP integration test.
@kcpevey
Copy link
Contributor

kcpevey commented Jul 17, 2024

@BrianCashProf can you resolve the pre-commit errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] - Colapse Cloud provider test into single workflow using custom actions and skip conditionals
2 participants