From 729b10b1091bc2f34bd38fa7db00a067f5d36f90 Mon Sep 17 00:00:00 2001
From: Amit Kumar <dtu.amit@gmail.com>
Date: Fri, 5 Nov 2021 12:38:55 +0000
Subject: [PATCH] Fix CI: skip failure on cleanup

---
 .cirun.yml                                                  | 2 +-
 .github/workflows/kubernetes_test.yaml                      | 6 +++++-
 .../infrastructure/kubernetes.tf                            | 6 ++++++
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/.cirun.yml b/.cirun.yml
index d261a6e50..313d3e315 100644
--- a/.cirun.yml
+++ b/.cirun.yml
@@ -7,7 +7,7 @@ runners:
     # Instance Type has 4 vcpu, 16 GiB memory, Up to 5 Gbps Network Performance
     instance_type: t3a.xlarge
     # Custom AMI with docker is pre-installed
-    machine_image: ami-08939857cf6893cde
+    machine_image: ami-0ff297f01f579288c
     # Region: Oregon
     region: us-west-2
     # Path of the relevant workflow file
diff --git a/.github/workflows/kubernetes_test.yaml b/.github/workflows/kubernetes_test.yaml
index e5a46a751..5bea5e702 100644
--- a/.github/workflows/kubernetes_test.yaml
+++ b/.github/workflows/kubernetes_test.yaml
@@ -95,6 +95,7 @@ jobs:
           cd local-deployment
           qhub deploy --config qhub-config.yaml --disable-prompt
       - name: Basic kubectl checks after deployment
+        if: always()
         run: |
           kubectl get all,cm,secret,ing -A
       - name: Check github-actions.qhub.dev resolves
@@ -150,7 +151,10 @@ jobs:
       - name: Cleanup qhub deployment
         run: |
           cd local-deployment
-          qhub destroy --config qhub-config.yaml
+          # This is a known failure at the moment.
+          qhub destroy --config qhub-config.yaml || true
+
       - name: Basic kubectl checks after cleanup
+        if: always()
         run: |
           kubectl get all,cm,secret,ing -A
diff --git a/qhub/template/{{ cookiecutter.repo_directory }}/infrastructure/kubernetes.tf b/qhub/template/{{ cookiecutter.repo_directory }}/infrastructure/kubernetes.tf
index 232787cbe..4793801d5 100644
--- a/qhub/template/{{ cookiecutter.repo_directory }}/infrastructure/kubernetes.tf	
+++ b/qhub/template/{{ cookiecutter.repo_directory }}/infrastructure/kubernetes.tf	
@@ -310,6 +310,9 @@ module "qhub" {
   keycloak_password   = random_password.keycloak-qhub-bot-password.result
   keycloak_server_url = "http://keycloak-headless.${var.environment}:8080/auth/"
 
+  depends_on = [
+    module.kubernetes-initialization
+  ]
 }
 
 {% if cookiecutter.prefect.enabled -%}
@@ -380,4 +383,7 @@ module "forwardauth" {
   jh-client-id      = local.forwardauth-keycloak-client-id
   jh-client-secret  = random_password.forwardauth-jhsecret.result
   callback-url-path = local.forwardauth-callback-url-path
+  depends_on = [
+    module.kubernetes-initialization
+  ]
 }