refactor: add deep merge for options

necordjs · Jan 13, 2024 · a725a5a · a725a5a
1 parent 99daa71
commit a725a5a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/necord-pagination.service.ts b/src/necord-pagination.service.ts
@@ -4,6 +4,7 @@ import { NecordPaginationOptions } from './interfaces';
 import { MODULE_OPTIONS_TOKEN } from './necord-pagination.module-definition';
 import { PaginationAction } from './enums';
 import { ButtonStyle } from 'discord.js';
+import * as deepMerge from 'deepmerge';
 
 @Injectable()
 export class NecordPaginationService {
@@ -47,14 +48,7 @@ export class NecordPaginationService {
 		@Inject(MODULE_OPTIONS_TOKEN)
 		private readonly options: NecordPaginationOptions
 	) {
-		this.options = {
-			...NecordPaginationService.DEFAULT_OPTIONS,
-			...options,
-			buttons: {
-				...NecordPaginationService.DEFAULT_OPTIONS.buttons,
-				...options.buttons
-			}
-		};
+		this.options = deepMerge(NecordPaginationService.DEFAULT_OPTIONS, options ?? {});
 	}
 
 	public register(factory: (builder: PaginationBuilder) => PaginationBuilder): PaginationBuilder {

diff --git a/test/utils.spec.ts b/test/utils.spec.ts
@@ -1,6 +1,6 @@
 import { NestFactory } from '@nestjs/core';
 import { Module, Provider } from '@nestjs/common';
-import { IntentsBitField } from "discord.js";
+import { IntentsBitField } from 'discord.js';
 import { NecordModule } from 'necord';
 import { NecordPaginationModule } from '../src';