Fix build on android, and with LOGGING_LEVEL = 0 #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the delay on this. I have been ill, and what we actually really need here is a CI compiling everything for Android going forth. |
ned14
added a commit
that referenced
this pull request
Nov 6, 2024
ned14
added a commit
that referenced
this pull request
Nov 6, 2024
ned14
added a commit
that referenced
this pull request
Nov 6, 2024
|
I think everything for this PR is now addressed. I didn't quite fix things as you did in your PR, however your PR was very useful in identifying what to change so thank you for that. There is now an Android CI runner to ensure Android support doesn't regress in the future. It currently doesn't pass, but I'm prevented by the Boost release cycle from fixing it. When the next release of Boost goes out, that CI job should go green. Thanks for the PR and sorry again about the wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes building with LLFIO_LOGGING_LEVEL = 0, and a couple of minor issues that arose when building for android.