Swap config_setting(constraint_values=[X]) -> X, where possible #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel no longer requires wrapping single constraint_value()s in config settings; they can be selected upon directly. This allows for some code to deleted and simplified. I've also added notes to the cases where we can't yet delete constraint_values, but will likely be able to in the near future, as well as the relevant blocking bugs.
Merged
nelhage
pushed a commit
that referenced
this pull request
Jan 25, 2022
I happened to see a C++1z while writing #247. Since it's 2022, I figured I'd quickly switch it out for C++17--and make sure it passed the test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, @nelhage, I went through the last category of cleanup I'd mentioned in #245 and did as much as could be done with Bazel 5.
To flag the bit that might be controversial: this does remove, e.g. @boost//:windows, as part of the public interface of these rules, but I think you probably want people using Bazel's @platforms// rather than no-longer-needed wrappings in this workspace.
More details from the commit message:
Bazel no longer requires wrapping single constraint_value()s in config settings; they can be selected upon directly. This allows for some code to deleted and simplified.
I've also added notes to the cases where we can't yet delete constraint_values, but will likely be able to in the near future, as well as the relevant blocking bugs.