Update deployment conditional check #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbekolay
approved these changes
Mar 16, 2020
tbekolay
force-pushed
the
deployment-condition
branch
from
0a30939 to
1b37bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
TravisCI updated their conditional deployment logic, the previous way of doing things now raises an error.
How has this been tested?
Pushed a test release-candidate branch and tag to see that the proper jobs were created (did not actually go through the deployment process, so it hasn't been completely tested in that sense).
How long should this take to review?
Types of changes:
Checklist: