Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance #256

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Maintenance #256

merged 2 commits into from
Jun 15, 2020

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Jun 14, 2020 •
edited
Loading

Motivation and context:

Some maintenance to be prepared for upcoming Python versions and remove on longer required code.

Interactions with other PRs:

none

How has this been tested?

existing tests

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • [n/a] I have updated the documentation accordingly.
  • [n/a] I have included a changelog entry.
  • [n/a] I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann jgosmann added this to the 1.1.0 milestone Jun 14, 2020
@jgosmann jgosmann requested review from Seanny123 and arvoelke June 14, 2020 18:27
jgosmann added 2 commits June 15, 2020 17:14
@jgosmann
Import ABCs from collections.abc
0af3c74 
Import directly from collections is deprecated and will stop working
with Python 3.9.

Fixes #253.
@jgosmann
Remove explicit derivations from object
28bb81e 
No longer required with Python 3 and Python 2 support was dropped.

Closes #241.
@jgosmann jgosmann merged commit 1c1c25f into master Jun 15, 2020
@jgosmann jgosmann deleted the maintenance branch June 15, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seanny123 Seanny123 Seanny123 approved these changes

@arvoelke arvoelke Awaiting requested review from arvoelke

Assignees
No one assigned
Labels
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jgosmann @Seanny123