fix(compiler): remove createMapIterator in some places #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencercorwin
force-pushed
the
fix-iterators
branch
from
2078dd8 to
f8ed34a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
NEWARRAY0instead of pushing 0 and then callingNEWARRAYcreateMapIteratorhelper) everywhere. Usually by using a new reduce helper or a forLoop helper.block.test.tsTest Plan
Various array and map builtin compiler tests.
Alternate Designs
None.
Benefits
Removes the use of very expensive and non-constant storage iterators which were/are being created with
createMapIteratorhelper. That helper was created as a work-around to the removal of the iterator APIs from the VM. But it turned out that this was not a great solution since it modified contract storage, causing nearly all contract methods to use storage (and thus not be "constant" methods) and caused contract call prices to go way up.Possible Drawbacks
None.
Applicable Issues
#2410