Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): add transfer api documentation and other fixes #2500

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

spencercorwin
Copy link
Collaborator

Description of the Change

  • Adds documentation for new compiler transfers API to the website docs
  • Adds the API to the ICO mixin and test coverage
  • Removes gasCost from some tests (doesn't exist any more)
  • Add notes to compileContract.ts for a potential new issue
  • Fixes up debugger output for N3 compiler changes and changes to the debugger spec
  • Fixes and cleans up the parsing of Actions produced by contract calls
  • Cleans up args.ts
  • Fixes notifications produced by our compiler by removing the redundant eventName item

Test Plan

  • TestICO.test.ts

Alternate Designs

None.

Benefits

  • Transfers API documented
  • Removes tons of bugs and cleans up the code
  • Fixes notifications produced by compiler

Possible Drawbacks

Possibly introduced bugs made incorrect fixes.

Applicable Issues

#2410
#2466
#2475

@spencercorwin spencercorwin merged commit 7f75272 into neo-one-suite:master Jul 1, 2021
@spencercorwin spencercorwin deleted the add-transfers branch July 1, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant