Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency @types/styled-components to v4.1.6 #982

Merged
merged 1 commit into from
Jan 24, 2019
Merged

chore(deps): update dependency @types/styled-components to v4.1.6 #982

merged 1 commit into from
Jan 24, 2019

Conversation

danwbyrne
Copy link
Contributor

Description of the Change

Do #758 but also add a type to an inferred any callback.

Test Plan

yarn tsc

Applicable Issues

#758

@danwbyrne danwbyrne requested a review from davemneo January 24, 2019 22:19
@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #982 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   72.29%   72.14%   -0.16%     
==========================================
  Files        1517     1517              
  Lines       43619    43619              
  Branches     6698     6698              
==========================================
- Hits        31535    31467      -68     
- Misses      12084    12152      +68
Flag Coverage Δ
#e2e 63.47% <ø> (-0.24%) ⬇️
#unit 61.99% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ne-node-core/src/transaction/PublishTransaction.ts 22.85% <0%> (-37.15%) ⬇️
...core/src/transaction/attribute/UInt256Attribute.ts 23.52% <0%> (-35.3%) ⬇️
...s/neo-one-node-protocol/src/payload/AddrPayload.ts 26.66% <0%> (-33.34%) ⬇️
...e-node-core/src/transaction/attribute/Attribute.ts 56.89% <0%> (-27.59%) ⬇️
...s/neo-one-node-core/src/transaction/Transaction.ts 76.92% <0%> (-5.13%) ⬇️
packages/neo-one-node-core/src/Contract.ts 82.35% <0%> (-2.95%) ⬇️
...neo-one-node-http-rpc/src/middleware/checkReady.ts 94.59% <0%> (-2.71%) ⬇️
packages/neo-one-node-protocol/src/Message.ts 51.23% <0%> (-2.47%) ⬇️
packages/neo-one-node-protocol/src/Node.ts 62.96% <0%> (-1.49%) ⬇️
packages/neo-one-node-network/src/Network.ts 81.92% <0%> (-1.21%) ⬇️
... and 2 more

3 similar comments
@codecov
Copy link

codecov bot commented Jan 24, 2019 •
edited
Loading

Codecov Report

Merging #982 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   72.29%   72.14%   -0.16%     
==========================================
  Files        1517     1517              
  Lines       43619    43619              
  Branches     6698     6698              
==========================================
- Hits        31535    31467      -68     
- Misses      12084    12152      +68
Flag Coverage Δ
#e2e 63.47% <ø> (-0.24%) ⬇️
#unit 61.99% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ne-node-core/src/transaction/PublishTransaction.ts 22.85% <0%> (-37.15%) ⬇️
...core/src/transaction/attribute/UInt256Attribute.ts 23.52% <0%> (-35.3%) ⬇️
...s/neo-one-node-protocol/src/payload/AddrPayload.ts 26.66% <0%> (-33.34%) ⬇️
...e-node-core/src/transaction/attribute/Attribute.ts 56.89% <0%> (-27.59%) ⬇️
...s/neo-one-node-core/src/transaction/Transaction.ts 76.92% <0%> (-5.13%) ⬇️
packages/neo-one-node-core/src/Contract.ts 82.35% <0%> (-2.95%) ⬇️
...neo-one-node-http-rpc/src/middleware/checkReady.ts 94.59% <0%> (-2.71%) ⬇️
packages/neo-one-node-protocol/src/Message.ts 51.23% <0%> (-2.47%) ⬇️
packages/neo-one-node-protocol/src/Node.ts 62.96% <0%> (-1.49%) ⬇️
packages/neo-one-node-network/src/Network.ts 81.92% <0%> (-1.21%) ⬇️
... and 2 more

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #982 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   72.29%   72.14%   -0.16%     
==========================================
  Files        1517     1517              
  Lines       43619    43619              
  Branches     6698     6698              
==========================================
- Hits        31535    31467      -68     
- Misses      12084    12152      +68
Flag Coverage Δ
#e2e 63.47% <ø> (-0.24%) ⬇️
#unit 61.99% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ne-node-core/src/transaction/PublishTransaction.ts 22.85% <0%> (-37.15%) ⬇️
...core/src/transaction/attribute/UInt256Attribute.ts 23.52% <0%> (-35.3%) ⬇️
...s/neo-one-node-protocol/src/payload/AddrPayload.ts 26.66% <0%> (-33.34%) ⬇️
...e-node-core/src/transaction/attribute/Attribute.ts 56.89% <0%> (-27.59%) ⬇️
...s/neo-one-node-core/src/transaction/Transaction.ts 76.92% <0%> (-5.13%) ⬇️
packages/neo-one-node-core/src/Contract.ts 82.35% <0%> (-2.95%) ⬇️
...neo-one-node-http-rpc/src/middleware/checkReady.ts 94.59% <0%> (-2.71%) ⬇️
packages/neo-one-node-protocol/src/Message.ts 51.23% <0%> (-2.47%) ⬇️
packages/neo-one-node-protocol/src/Node.ts 62.96% <0%> (-1.49%) ⬇️
packages/neo-one-node-network/src/Network.ts 81.92% <0%> (-1.21%) ⬇️
... and 2 more

@codecov
Copy link

codecov bot commented Jan 24, 2019 •
edited
Loading

Codecov Report

Merging #982 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   72.29%   72.14%   -0.16%     
==========================================
  Files        1517     1517              
  Lines       43619    43619              
  Branches     6698     6698              
==========================================
- Hits        31535    31467      -68     
- Misses      12084    12152      +68
Flag Coverage Δ
#e2e 63.47% <ø> (-0.24%) ⬇️
#unit 61.99% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ne-node-core/src/transaction/PublishTransaction.ts 22.85% <0%> (-37.15%) ⬇️
...core/src/transaction/attribute/UInt256Attribute.ts 23.52% <0%> (-35.3%) ⬇️
...s/neo-one-node-protocol/src/payload/AddrPayload.ts 26.66% <0%> (-33.34%) ⬇️
...e-node-core/src/transaction/attribute/Attribute.ts 56.89% <0%> (-27.59%) ⬇️
...s/neo-one-node-core/src/transaction/Transaction.ts 76.92% <0%> (-5.13%) ⬇️
packages/neo-one-node-core/src/Contract.ts 82.35% <0%> (-2.95%) ⬇️
...neo-one-node-http-rpc/src/middleware/checkReady.ts 94.59% <0%> (-2.71%) ⬇️
packages/neo-one-node-protocol/src/Message.ts 51.23% <0%> (-2.47%) ⬇️
packages/neo-one-node-protocol/src/Node.ts 62.96% <0%> (-1.49%) ⬇️
packages/neo-one-node-network/src/Network.ts 81.92% <0%> (-1.21%) ⬇️
... and 2 more

@dicarlo2
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Jan 24, 2019
@bors @renovate-bot
Merge #982
c6e3937 
982: chore(deps): update dependency @types/styled-components to v4.1.6 r=dicarlo2 a=danwbyrne

### Description of the Change

Do #758 but also add a type to an inferred any callback.

### Test Plan

```
yarn tsc
```


### Applicable Issues

#758 


Co-authored-by: Renovate Bot <bot@renovateapp.com>
@bors
Copy link
Contributor

bors bot commented Jan 24, 2019

Build succeeded

@bors bors bot merged commit 610e9ed into neo-one-suite:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicarlo2 dicarlo2 dicarlo2 approved these changes

@davemneo davemneo Awaiting requested review from davemneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danwbyrne @dicarlo2 @renovate-bot