Migrate tests from java driver #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate tests from java driver This updated also includes: - TransactionClose request support (`Temporary:TransactionClose` feature) - Driver fetch size configuration (`Temporary:DriverFetchSize` feature) Migrated tests: - shouldThrowRollbackErrorWhenTransactionRollback -> test_should_error_on_rollback_failure_using_tx_rollback - shouldThrowRollbackErrorWhenTransactionClose -> test_should_error_on_rollback_failure_using_tx_close - shouldPropagateTransactionRollbackErrorWhenSessionClosed -> test_should_error_on_rollback_failure_using_session_close - shouldStreamingRecordsInBatches -> test_should_accept_custom_fetch_size_using_driver_configuration (protocol bump from 4 to 4.1) - shouldChangeFetchSize -> test_should_accept_custom_fetch_size_using_session_configuration (protocol bump from 4 to 4.1) * Update TMP_DRIVER_FETCH_SIZE feature comment * Update _assert_is_transient_exception check for java driver * Remove pipelining from direct scripts and update fetchSize handling * Add optional RESET to writer_with_custom_fetch_size.script * Skip direct rollback tests for go and javascript * Skip direct rollback test for javascript * Skip test_should_error_on_rollback_failure_using_session_close for dotnet
robsdedude
approved these changes
Aug 11, 2021
Contributor
robsdedude
left a comment
robsdedude
left a comment
There was a problem hiding this comment.
🍒
LGTM as soon as the pipelines are green.
Contributor
Author
|
Java fixed in: neo4j/neo4j-java-driver#977. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks: #206 and #210.