Skip to content

Commit

Permalink
Updates node version in code and CI (#210)
Browse files Browse the repository at this point in the history
  • Loading branch information
ncordon authored May 13, 2024
1 parent aac11db commit 78b265d
Show file tree
Hide file tree
Showing 9 changed files with 279 additions and 231 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup antlr4
uses: ./.github/actions/setup-antlr4
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
name: Run eslint and check formatting
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup antlr4
uses: ./.github/actions/setup-antlr4
Expand All @@ -40,7 +40,7 @@ jobs:
name: Unit tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup antlr4
uses: ./.github/actions/setup-antlr4
Expand All @@ -59,7 +59,7 @@ jobs:
timeout-minutes: 60
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup antlr4
uses: ./.github/actions/setup-antlr4
Expand All @@ -78,7 +78,7 @@ jobs:
# https://code.visualstudio.com/api/working-with-extensions/continuous-integration#github-actions
run: xvfb-run -a npm run test:e2e

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/deploy-demo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Pages
uses: actions/configure-pages@v3
uses: actions/configure-pages@v5

- name: Setup antlr4
uses: ./.github/actions/setup-antlr4
Expand All @@ -46,10 +46,10 @@ jobs:
run: npm run build

- name: Upload artifact
uses: actions/upload-pages-artifact@v1
uses: actions/upload-pages-artifact@v3
with:
path: './packages/react-codemirror-playground/dist/'

- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v2
uses: actions/deploy-pages@v4
12 changes: 6 additions & 6 deletions .github/workflows/publish-npm-packages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: Setup antlr4
uses: ./.github/actions/setup-antlr4
Expand All @@ -41,11 +41,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
registry-url: 'https://registry.npmjs.org'

- name: Setup antlr4
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-vscode-extension.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: Setup antlr4
uses: ./.github/actions/setup-antlr4
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.18.2
20.11.1
Loading

0 comments on commit 78b265d

Please sign in to comment.