Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop shading dependencies in neo4j-java-driver package #1222

Merged
merged 1 commit into from
May 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bundle/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
Aggregator project for building the single JAR with shaded dependencies.

This module aggregates the slim version, unpacks it and repackages it.
The sources are unpacked so that an individual JavaDoc artifact is produced, too.
This module aggregates neo4j-java-driver, unpacks it and repackages it. The sources are unpacked so that an individual JavaDoc artifact is produced, too.
10 changes: 5 additions & 5 deletions bundle/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
<relativePath>..</relativePath>
</parent>

<artifactId>neo4j-java-driver</artifactId>
<artifactId>neo4j-java-driver-all</artifactId>

<packaging>jar</packaging>
<name>Neo4j Java Driver</name>
<name>Neo4j Java Driver (shaded package)</name>
<description>Access to the Neo4j graph database through Java</description>

<properties>
Expand All @@ -26,7 +26,7 @@
<!-- The original driver that will be repackaged. -->
<dependency>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-slim</artifactId>
<artifactId>neo4j-java-driver</artifactId>
<version>${project.version}</version>
<optional>true</optional>
</dependency>
Expand Down Expand Up @@ -68,7 +68,7 @@
<goal>copy-resources</goal>
</goals>
<configuration>
<outputDirectory>${project.build.directory}/generated-sources/slim</outputDirectory>
<outputDirectory>${project.build.directory}/generated-sources/neo4j-java-driver</outputDirectory>
<overwrite>true</overwrite>
<resources>
<resource>
Expand All @@ -93,7 +93,7 @@
</goals>
<configuration>
<sources>
<source>${project.build.directory}/generated-sources/slim</source>
<source>${project.build.directory}/generated-sources/neo4j-java-driver</source>
</sources>
</configuration>
</execution>
Expand Down
4 changes: 2 additions & 2 deletions driver/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
<version>5.0-SNAPSHOT</version>
</parent>

<artifactId>neo4j-java-driver-slim</artifactId>
<artifactId>neo4j-java-driver</artifactId>

<packaging>jar</packaging>
<name>Neo4j Java Driver (Slim package)</name>
<name>Neo4j Java Driver</name>
<description>Access to the Neo4j graph database through Java</description>

<properties>
Expand Down
2 changes: 1 addition & 1 deletion examples/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<!-- Test dependencies -->
<dependency>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-slim</artifactId>
<artifactId>neo4j-java-driver</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
Expand Down
2 changes: 1 addition & 1 deletion testkit-backend/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<dependencies>
<dependency>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-slim</artifactId>
<artifactId>neo4j-java-driver</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
Expand Down