diff --git a/driver/src/test/java/org/neo4j/driver/ParametersTest.java b/driver/src/test/java/org/neo4j/driver/ParametersTest.java index 39b2c542b5..c54ca20cdf 100644 --- a/driver/src/test/java/org/neo4j/driver/ParametersTest.java +++ b/driver/src/test/java/org/neo4j/driver/ParametersTest.java @@ -73,6 +73,7 @@ void shouldGiveHelpfulMessageOnMisalignedInput(Object obj, String expectedMsg) { @ParameterizedTest @MethodSource("addressesToParse") + @SuppressWarnings("resource") void shouldNotBePossibleToUseInvalidParameterTypesViaParameters(Object obj, String expectedMsg) { var session = mockedSession(); var e = assertThrows(ClientException.class, () -> session.run("RETURN {a}", parameters("a", obj))); @@ -81,6 +82,7 @@ void shouldNotBePossibleToUseInvalidParameterTypesViaParameters(Object obj, Stri @ParameterizedTest @MethodSource("addressesToParse") + @SuppressWarnings("resource") void shouldNotBePossibleToUseInvalidParametersViaMap(Object obj, String expectedMsg) { var session = mockedSession(); var e = assertThrows(ClientException.class, () -> session.run("RETURN {a}", singletonMap("a", obj))); @@ -89,6 +91,7 @@ void shouldNotBePossibleToUseInvalidParametersViaMap(Object obj, String expected @ParameterizedTest @MethodSource("addressesToParse") + @SuppressWarnings("resource") void shouldNotBePossibleToUseInvalidParametersViaRecord(Object obj, String expectedMsg) { assumeTrue(obj instanceof Value); Record record = new InternalRecord(singletonList("a"), new Value[] {(Value) obj}); diff --git a/driver/src/test/java/org/neo4j/driver/integration/ChannelConnectorImplIT.java b/driver/src/test/java/org/neo4j/driver/integration/ChannelConnectorImplIT.java index af2082ab28..95a30ee25c 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/ChannelConnectorImplIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/ChannelConnectorImplIT.java @@ -166,6 +166,7 @@ void shouldFailWhenTLSHandshakeTakesTooLong() throws Exception { } @Test + @SuppressWarnings("resource") void shouldThrowServiceUnavailableExceptionOnFailureDuringConnect() throws Exception { var server = new ServerSocket(0); var address = new BoltServerAddress("localhost", server.getLocalPort()); diff --git a/driver/src/test/java/org/neo4j/driver/integration/QueryRunnerCloseIT.java b/driver/src/test/java/org/neo4j/driver/integration/QueryRunnerCloseIT.java index b26ad2146b..44138cc404 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/QueryRunnerCloseIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/QueryRunnerCloseIT.java @@ -51,6 +51,7 @@ void tearDown() { } @Test + @SuppressWarnings("resource") void shouldErrorToAccessRecordsAfterConsume() { // Given var result = neo4j.driver().session().run("UNWIND [1,2] AS a RETURN a"); @@ -70,6 +71,7 @@ void shouldErrorToAccessRecordsAfterConsume() { } @Test + @SuppressWarnings("resource") void shouldErrorToAccessRecordsAfterClose() { // Given var session = neo4j.driver().session(); @@ -90,6 +92,7 @@ void shouldErrorToAccessRecordsAfterClose() { } @Test + @SuppressWarnings("resource") void shouldAllowConsumeAndKeysAfterConsume() { // Given var result = neo4j.driver().session().run("UNWIND [1,2] AS a RETURN a"); @@ -107,6 +110,7 @@ void shouldAllowConsumeAndKeysAfterConsume() { } @Test + @SuppressWarnings("resource") void shouldAllowSummaryAndKeysAfterClose() { // Given var session = neo4j.driver().session(); @@ -126,6 +130,7 @@ void shouldAllowSummaryAndKeysAfterClose() { } @Test + @SuppressWarnings("resource") void shouldErrorToAccessRecordsAfterConsumeAsync() { // Given var session = neo4j.driver().session(AsyncSession.class); @@ -144,6 +149,7 @@ void shouldErrorToAccessRecordsAfterConsumeAsync() { } @Test + @SuppressWarnings("resource") void shouldErrorToAccessRecordsAfterCloseAsync() { // Given var session = neo4j.driver().session(AsyncSession.class); @@ -162,6 +168,7 @@ void shouldErrorToAccessRecordsAfterCloseAsync() { } @Test + @SuppressWarnings("resource") void shouldAllowConsumeAndKeysAfterConsumeAsync() { // Given var session = neo4j.driver().session(AsyncSession.class); @@ -181,6 +188,7 @@ void shouldAllowConsumeAndKeysAfterConsumeAsync() { } @Test + @SuppressWarnings("resource") void shouldAllowConsumeAndKeysAfterCloseAsync() { // Given var session = neo4j.driver().session(AsyncSession.class); diff --git a/driver/src/test/java/org/neo4j/driver/integration/SessionBoltV3IT.java b/driver/src/test/java/org/neo4j/driver/integration/SessionBoltV3IT.java index 4f2816f263..489d8514a8 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/SessionBoltV3IT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/SessionBoltV3IT.java @@ -73,6 +73,7 @@ void beforeAll() { } @Test + @SuppressWarnings("resource") void shouldSetTransactionMetadata() { Map metadata = new HashMap<>(); metadata.put("a", "hello world"); @@ -104,6 +105,7 @@ void shouldSetTransactionMetadataAsync() { } @Test + @SuppressWarnings("resource") void shouldSetTransactionTimeout() { // create a dummy node var session = driver.session(); @@ -128,6 +130,7 @@ void shouldSetTransactionTimeout() { } @Test + @SuppressWarnings("resource") void shouldSetTransactionTimeoutAsync() { // create a dummy node var asyncSession = driver.asyncSession(); diff --git a/driver/src/test/java/org/neo4j/driver/integration/SessionIT.java b/driver/src/test/java/org/neo4j/driver/integration/SessionIT.java index ee7c3f1aad..84d5cb721e 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/SessionIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/SessionIT.java @@ -116,6 +116,7 @@ void tearDown() { } @Test + @SuppressWarnings("resource") void shouldKnowSessionIsClosed() { // Given var session = neo4j.driver().session(); @@ -532,6 +533,7 @@ void writeTxRolledBackWhenRollbackAndThrowsException() { } @Test + @SuppressWarnings("resource") void transactionRunShouldFailOnDeadlocks() throws Exception { final var nodeId1 = 42; final var nodeId2 = 4242; @@ -589,7 +591,7 @@ void transactionRunShouldFailOnDeadlocks() throws Exception { } @Test - @SuppressWarnings("deprecation") + @SuppressWarnings({"deprecation", "resource"}) void writeTransactionFunctionShouldRetryDeadlocks() throws Exception { final var nodeId1 = 42; final var nodeId2 = 4242; @@ -669,7 +671,7 @@ void writeTransactionFunctionShouldRetryDeadlocks() throws Exception { } @Test - @SuppressWarnings("deprecation") + @SuppressWarnings({"deprecation", "resource"}) void shouldExecuteTransactionWorkInCallerThread() { var maxFailures = 3; var callerThread = Thread.currentThread(); @@ -693,6 +695,7 @@ public String execute(Transaction tx) { } @Test + @SuppressWarnings("resource") void shouldThrowRunFailureImmediatelyAndCloseSuccessfully() { try (var session = neo4j.driver().session()) { var e = assertThrows(ClientException.class, () -> session.run("RETURN 1 * \"x\"")); @@ -703,6 +706,7 @@ void shouldThrowRunFailureImmediatelyAndCloseSuccessfully() { @EnabledOnNeo4jWith(BOLT_V4) @Test + @SuppressWarnings("resource") void shouldNotPropagateFailureWhenStreamingIsCancelled() { var session = neo4j.driver().session(); session.run("UNWIND range(20000, 0, -1) AS x RETURN 10 / x"); @@ -710,6 +714,7 @@ void shouldNotPropagateFailureWhenStreamingIsCancelled() { } @Test + @SuppressWarnings("resource") void shouldNotBePossibleToConsumeResultAfterSessionIsClosed() { Result result; try (var session = neo4j.driver().session()) { @@ -722,6 +727,7 @@ void shouldNotBePossibleToConsumeResultAfterSessionIsClosed() { } @Test + @SuppressWarnings("resource") void shouldThrowRunFailureImmediatelyAfterMultipleSuccessfulRunsAndCloseSuccessfully() { try (var session = neo4j.driver().session()) { session.run("CREATE ()"); @@ -734,6 +740,7 @@ void shouldThrowRunFailureImmediatelyAfterMultipleSuccessfulRunsAndCloseSuccessf } @Test + @SuppressWarnings("resource") void shouldThrowRunFailureImmediatelyAndAcceptSubsequentRun() { try (var session = neo4j.driver().session()) { session.run("CREATE ()"); @@ -745,6 +752,7 @@ void shouldThrowRunFailureImmediatelyAndAcceptSubsequentRun() { } @Test + @SuppressWarnings("resource") void shouldCloseCleanlyWhenRunErrorConsumed() { var session = neo4j.driver().session(); @@ -761,6 +769,7 @@ void shouldCloseCleanlyWhenRunErrorConsumed() { } @Test + @SuppressWarnings("resource") void shouldConsumePreviousResultBeforeRunningNewQuery() { try (var session = neo4j.driver().session()) { session.run("UNWIND range(1000, 0, -1) AS x RETURN 42 / x"); @@ -797,6 +806,7 @@ void shouldNotRetryOnConnectionAcquisitionTimeout() { } @Test + @SuppressWarnings("resource") void shouldReportFailureInClose() { var session = neo4j.driver().session(); @@ -807,6 +817,7 @@ void shouldReportFailureInClose() { } @Test + @SuppressWarnings("resource") void shouldNotAllowAccessingRecordsAfterSummary() { var recordCount = 10_000; var query = "UNWIND range(1, " + recordCount + ") AS x RETURN x"; @@ -823,6 +834,7 @@ void shouldNotAllowAccessingRecordsAfterSummary() { } @Test + @SuppressWarnings("resource") void shouldNotAllowAccessingRecordsAfterSessionClosed() { var recordCount = 11_333; var query = "UNWIND range(1, " + recordCount + ") AS x RETURN 'Result-' + x"; @@ -837,6 +849,7 @@ void shouldNotAllowAccessingRecordsAfterSessionClosed() { @Test @DisabledOnNeo4jWith(BOLT_V4) + @SuppressWarnings("resource") void shouldAllowToConsumeRecordsSlowlyAndCloseSession() throws InterruptedException { var session = neo4j.driver().session(); @@ -854,6 +867,7 @@ void shouldAllowToConsumeRecordsSlowlyAndCloseSession() throws InterruptedExcept } @Test + @SuppressWarnings("resource") void shouldAllowToConsumeRecordsSlowlyAndRetrieveSummary() throws InterruptedException { try (var session = neo4j.driver().session()) { var result = session.run("UNWIND range(8000, 1, -1) AS x RETURN 42 / x"); @@ -871,6 +885,7 @@ void shouldAllowToConsumeRecordsSlowlyAndRetrieveSummary() throws InterruptedExc } @Test + @SuppressWarnings("resource") void shouldBeResponsiveToThreadInterruptWhenWaitingForResult() { try (var session1 = neo4j.driver().session(); var session2 = neo4j.driver().session()) { @@ -941,7 +956,7 @@ void shouldAllowLongRunningQueryWithConnectTimeout() throws Exception { } @Test - @SuppressWarnings("deprecation") + @SuppressWarnings({"deprecation", "resource"}) void shouldAllowReturningNullFromTransactionFunction() { try (var session = neo4j.driver().session()) { assertNull(session.readTransaction(tx -> null)); @@ -950,6 +965,7 @@ void shouldAllowReturningNullFromTransactionFunction() { } @Test + @SuppressWarnings("resource") void shouldAllowIteratingOverEmptyResult() { try (var session = neo4j.driver().session()) { var result = session.run("UNWIND [] AS x RETURN x"); @@ -960,6 +976,7 @@ void shouldAllowIteratingOverEmptyResult() { } @Test + @SuppressWarnings("resource") void shouldAllowConsumingEmptyResult() { try (var session = neo4j.driver().session()) { var result = session.run("UNWIND [] AS x RETURN x"); @@ -970,6 +987,7 @@ void shouldAllowConsumingEmptyResult() { } @Test + @SuppressWarnings("resource") void shouldAllowListEmptyResult() { try (var session = neo4j.driver().session()) { var result = session.run("UNWIND [] AS x RETURN x"); @@ -978,6 +996,7 @@ void shouldAllowListEmptyResult() { } @Test + @SuppressWarnings("resource") void shouldReportFailureInSummary() { try (var session = neo4j.driver().session()) { var query = "UNWIND [1, 2, 3, 4, 0] AS x RETURN 10 / x"; @@ -992,6 +1011,7 @@ void shouldReportFailureInSummary() { } @Test + @SuppressWarnings("resource") void shouldNotAllowStartingMultipleTransactions() { try (var session = neo4j.driver().session()) { var tx = session.beginTransaction(); @@ -1011,6 +1031,7 @@ void shouldNotAllowStartingMultipleTransactions() { } @Test + @SuppressWarnings("resource") void shouldCloseOpenTransactionWhenClosed() { try (var session = neo4j.driver().session()) { var tx = session.beginTransaction(); @@ -1025,6 +1046,7 @@ void shouldCloseOpenTransactionWhenClosed() { } @Test + @SuppressWarnings("resource") void shouldRollbackOpenTransactionWhenClosed() { try (var session = neo4j.driver().session()) { var tx = session.beginTransaction(); @@ -1039,6 +1061,7 @@ void shouldRollbackOpenTransactionWhenClosed() { } @Test + @SuppressWarnings("resource") void shouldSupportNestedQueries() { try (var session = neo4j.driver().session()) { // populate db with test data @@ -1068,7 +1091,7 @@ void shouldSupportNestedQueries() { @Test @DisabledOnNeo4jWith(BOLT_V4) - @SuppressWarnings("deprecation") + @SuppressWarnings({"deprecation", "resource"}) void shouldErrorWhenTryingToUseRxAPIWithoutBoltV4() { // Given var session = neo4j.driver().rxSession(); @@ -1089,6 +1112,7 @@ void shouldErrorWhenTryingToUseRxAPIWithoutBoltV4() { @Test @DisabledOnNeo4jWith(BOLT_V4) + @SuppressWarnings("resource") void shouldErrorWhenTryingToUseDatabaseNameWithoutBoltV4() { // Given var session = neo4j.driver().session(forDatabase("foo")); @@ -1102,6 +1126,7 @@ void shouldErrorWhenTryingToUseDatabaseNameWithoutBoltV4() { @Test @DisabledOnNeo4jWith(BOLT_V4) + @SuppressWarnings("resource") void shouldErrorWhenTryingToUseDatabaseNameWithoutBoltV4UsingTx() { // Given var session = neo4j.driver().session(forDatabase("foo")); @@ -1115,6 +1140,7 @@ void shouldErrorWhenTryingToUseDatabaseNameWithoutBoltV4UsingTx() { @Test @EnabledOnNeo4jWith(BOLT_V4) + @SuppressWarnings("resource") void shouldAllowDatabaseName() { // Given try (var session = neo4j.driver().session(forDatabase("neo4j"))) { @@ -1125,6 +1151,7 @@ void shouldAllowDatabaseName() { @Test @EnabledOnNeo4jWith(BOLT_V4) + @SuppressWarnings("resource") void shouldAllowDatabaseNameUsingTx() { try (var session = neo4j.driver().session(forDatabase("neo4j")); var transaction = session.beginTransaction()) { @@ -1135,7 +1162,7 @@ void shouldAllowDatabaseNameUsingTx() { @Test @EnabledOnNeo4jWith(BOLT_V4) - @SuppressWarnings("deprecation") + @SuppressWarnings({"deprecation", "resource"}) void shouldAllowDatabaseNameUsingTxWithRetries() { try (var session = neo4j.driver().session(forDatabase("neo4j"))) { int num = session.readTransaction( @@ -1146,6 +1173,7 @@ void shouldAllowDatabaseNameUsingTxWithRetries() { @Test @EnabledOnNeo4jWith(BOLT_V4) + @SuppressWarnings("resource") void shouldErrorDatabaseWhenDatabaseIsAbsent() { var session = neo4j.driver().session(forDatabase("foo")); @@ -1160,6 +1188,7 @@ void shouldErrorDatabaseWhenDatabaseIsAbsent() { @Test @EnabledOnNeo4jWith(BOLT_V4) + @SuppressWarnings("resource") void shouldErrorDatabaseNameUsingTxWhenDatabaseIsAbsent() { // Given var session = neo4j.driver().session(forDatabase("foo")); @@ -1176,7 +1205,7 @@ void shouldErrorDatabaseNameUsingTxWhenDatabaseIsAbsent() { @Test @EnabledOnNeo4jWith(BOLT_V4) - @SuppressWarnings("deprecation") + @SuppressWarnings({"deprecation", "resource"}) void shouldErrorDatabaseNameUsingTxWithRetriesWhenDatabaseIsAbsent() { // Given var session = neo4j.driver().session(forDatabase("foo")); @@ -1191,6 +1220,7 @@ void shouldErrorDatabaseNameUsingTxWithRetriesWhenDatabaseIsAbsent() { @ParameterizedTest @MethodSource("managedTransactionsReturningResult") + @SuppressWarnings("resource") void shouldErrorWhenResultIsReturned(Function fn) { // GIVEN var session = neo4j.driver().session(); @@ -1212,7 +1242,7 @@ static List> managedTransactionsReturningResult() { session -> session.executeRead(tx -> tx.run("RETURN 1"))); } - @SuppressWarnings("deprecation") + @SuppressWarnings({"deprecation", "resource"}) private void testExecuteReadTx(AccessMode sessionMode) { var driver = neo4j.driver(); @@ -1237,7 +1267,7 @@ private void testExecuteReadTx(AccessMode sessionMode) { } } - @SuppressWarnings("deprecation") + @SuppressWarnings({"deprecation", "resource"}) private void testExecuteWriteTx(AccessMode sessionMode) { var driver = neo4j.driver(); @@ -1261,7 +1291,7 @@ var record = session.run("MATCH (s:Shield) RETURN s.material").single(); } } - @SuppressWarnings("deprecation") + @SuppressWarnings({"deprecation", "resource"}) private void testTxRollbackWhenFunctionThrows(AccessMode sessionMode) { var driver = neo4j.driver(); @@ -1312,6 +1342,7 @@ private static ThrowingWork newThrowingWorkSpy(String query, int failures) { return spy(new ThrowingWork(query, failures)); } + @SuppressWarnings("resource") private int countNodesWithId(int id) { try (var session = neo4j.driver().session()) { var result = session.run("MATCH (n {id: $id}) RETURN count(n)", parameters("id", id)); @@ -1319,6 +1350,7 @@ private int countNodesWithId(int id) { } } + @SuppressWarnings("resource") private void createNodeWithId(int id) { try (var session = neo4j.driver().session()) { session.run("CREATE (n {id: $id})", parameters("id", id)); diff --git a/driver/src/test/java/org/neo4j/driver/integration/SessionMixIT.java b/driver/src/test/java/org/neo4j/driver/integration/SessionMixIT.java index 67e74e4434..e37fd800a2 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/SessionMixIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/SessionMixIT.java @@ -68,10 +68,12 @@ void tearDown() { session.close(); } + @SuppressWarnings("resource") private AsyncSession newAsyncSession() { return neo4j.driver().session(AsyncSession.class); } + @SuppressWarnings("resource") private Session newSession() { return neo4j.driver().session(); } diff --git a/driver/src/test/java/org/neo4j/driver/integration/SessionResetIT.java b/driver/src/test/java/org/neo4j/driver/integration/SessionResetIT.java index 9b097ebb12..409b2ba2c0 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/SessionResetIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/SessionResetIT.java @@ -119,6 +119,7 @@ void shouldTerminateQueriesInUnmanagedTransactionsRandomly() throws Exception { } @Test + @SuppressWarnings("resource") void shouldAllowMoreQueriesAfterSessionReset() { // Given try (var session = (InternalSession) neo4j.driver().session()) { @@ -134,6 +135,7 @@ void shouldAllowMoreQueriesAfterSessionReset() { } @Test + @SuppressWarnings("resource") void shouldAllowMoreTxAfterSessionReset() { // Given try (var session = (InternalSession) neo4j.driver().session()) { @@ -154,6 +156,7 @@ void shouldAllowMoreTxAfterSessionReset() { } @Test + @SuppressWarnings("resource") void shouldMarkTxAsFailedAndDisallowRunAfterSessionReset() { // Given try (var session = (InternalSession) neo4j.driver().session()) { @@ -170,6 +173,7 @@ void shouldMarkTxAsFailedAndDisallowRunAfterSessionReset() { } @Test + @SuppressWarnings("resource") void shouldAllowMoreTxAfterSessionResetInTx() { // Given try (var session = (InternalSession) neo4j.driver().session()) { @@ -208,6 +212,7 @@ void performUpdate( } @Test + @SuppressWarnings("resource") void resetShouldStopTransactionWaitingForALock() throws Exception { testResetOfQueryWaitingForLock(new NodeIdUpdater() { @Override @@ -260,6 +265,7 @@ public void performUpdate( } @Test + @SuppressWarnings("resource") void shouldBeAbleToRunMoreQueriesAfterResetOnNoErrorState() { try (var session = (InternalSession) neo4j.driver().session()) { // Given @@ -278,6 +284,7 @@ void shouldBeAbleToRunMoreQueriesAfterResetOnNoErrorState() { } @Test + @SuppressWarnings("resource") void shouldHandleResetBeforeRun() { try (var session = (InternalSession) neo4j.driver().session(); var tx = session.beginTransaction()) { @@ -288,6 +295,7 @@ void shouldHandleResetBeforeRun() { } @Test + @SuppressWarnings("resource") void shouldHandleResetFromMultipleThreads() throws Throwable { var session = (InternalSession) neo4j.driver().session(); @@ -331,6 +339,7 @@ void shouldHandleResetFromMultipleThreads() throws Throwable { assertEquals(1, countNodes("SecondNode")); } + @SuppressWarnings("resource") private void testResetOfQueryWaitingForLock(NodeIdUpdater nodeIdUpdater) throws Exception { var nodeId = 42; var newNodeId1 = 4242; @@ -364,6 +373,7 @@ private void testResetOfQueryWaitingForLock(NodeIdUpdater nodeIdUpdater) throws } } + @SuppressWarnings("resource") private void createNodeWithId(int id) { try (var session = neo4j.driver().session()) { session.run("CREATE (n {id: $id})", parameters("id", id)); @@ -408,6 +418,7 @@ private void testRandomQueryTermination(boolean autoCommit) throws InterruptedEx awaitNoActiveQueries(); } + @SuppressWarnings("resource") private void runRandomQuery( boolean autoCommit, Random random, Set runningSessions, AtomicBoolean stop) { try { @@ -437,6 +448,7 @@ private void testQueryTermination(boolean autoCommit) { awaitNoActiveQueries(); } + @SuppressWarnings("resource") private Future runQueryInDifferentThreadAndResetSession(String query, boolean autoCommit) { var sessionRef = new AtomicReference(); @@ -474,6 +486,7 @@ private void awaitActiveQueriesToContain(String value) { awaitCondition(() -> activeQueryNames(neo4j.driver()).stream().anyMatch(query -> query.contains(value))); } + @SuppressWarnings("resource") private long countNodes(String label) { try (var session = neo4j.driver().session()) { var result = session.run("MATCH (n" + (label == null ? "" : ":" + label) + ") RETURN count(n) AS result"); diff --git a/driver/src/test/java/org/neo4j/driver/integration/SummaryIT.java b/driver/src/test/java/org/neo4j/driver/integration/SummaryIT.java index da893aa534..16bb748f48 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/SummaryIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/SummaryIT.java @@ -50,6 +50,7 @@ class SummaryIT { private Session session; @BeforeEach + @SuppressWarnings("resource") void setup() { session = neo4j.driver().session(); } @@ -172,6 +173,7 @@ void shouldContainCorrectStatistics() { @Test @EnabledOnNeo4jWith(Neo4jFeature.BOLT_V4) + @SuppressWarnings("resource") void shouldGetSystemUpdates() { try (var session = neo4j.driver().session(forDatabase("system"))) { var result = session.run("CREATE USER foo SET PASSWORD 'Testing0'"); diff --git a/driver/src/test/java/org/neo4j/driver/integration/TransactionBoltV3IT.java b/driver/src/test/java/org/neo4j/driver/integration/TransactionBoltV3IT.java index f7226c18d2..84ef285901 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/TransactionBoltV3IT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/TransactionBoltV3IT.java @@ -60,6 +60,7 @@ void beforeAll() { } @Test + @SuppressWarnings("resource") void shouldSetTransactionMetadata() { Map metadata = new HashMap<>(); metadata.put("key1", "value1"); @@ -96,6 +97,7 @@ void shouldSetTransactionMetadataAsync() { } @Test + @SuppressWarnings("resource") void shouldSetTransactionTimeout() { // create a dummy node var session = driver.session(); @@ -125,6 +127,7 @@ void shouldSetTransactionTimeout() { } @Test + @SuppressWarnings("resource") void shouldSetTransactionTimeoutAsync() { // create a dummy node var session = driver.session(); @@ -164,6 +167,7 @@ private static void verifyValidException(Exception error) { } } + @SuppressWarnings("resource") private static void verifyTransactionMetadata(Map metadata) { try (var session = driver.driver().session()) { var result = session.run(showTxMetadata); diff --git a/driver/src/test/java/org/neo4j/driver/integration/TrustCustomCertificateIT.java b/driver/src/test/java/org/neo4j/driver/integration/TrustCustomCertificateIT.java index 80b5106134..63d1851e43 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/TrustCustomCertificateIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/TrustCustomCertificateIT.java @@ -61,6 +61,7 @@ void shouldAcceptServerWithSameCertificate() { } @Test + @SuppressWarnings("resource") void shouldRejectServerWithUntrustedCertificate() throws Throwable { // Given a driver with a (random) cert var certificateAndKey = createNewCertificateAndKey(); diff --git a/driver/src/test/java/org/neo4j/driver/integration/UnmanagedTransactionIT.java b/driver/src/test/java/org/neo4j/driver/integration/UnmanagedTransactionIT.java index e452b217e5..8854a2ea92 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/UnmanagedTransactionIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/UnmanagedTransactionIT.java @@ -61,6 +61,7 @@ class UnmanagedTransactionIT { private NetworkSession session; @BeforeEach + @SuppressWarnings("resource") void setUp() { session = ((InternalDriver) neo4j.driver()).newSession(SessionConfig.defaultConfig(), null); } diff --git a/driver/src/test/java/org/neo4j/driver/integration/UnsupportedBoltV3IT.java b/driver/src/test/java/org/neo4j/driver/integration/UnsupportedBoltV3IT.java index d63f83b2e6..ea37d11ddd 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/UnsupportedBoltV3IT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/UnsupportedBoltV3IT.java @@ -48,6 +48,7 @@ class UnsupportedBoltV3IT { .build(); @Test + @SuppressWarnings("resource") void shouldNotSupportAutoCommitQueriesWithTransactionConfig() { assertTxConfigNotSupported(() -> driver.session().run("RETURN 42", txConfig)); } diff --git a/driver/src/test/java/org/neo4j/driver/integration/async/AsyncQueryIT.java b/driver/src/test/java/org/neo4j/driver/integration/async/AsyncQueryIT.java index d27f0fc597..787d5cea9a 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/async/AsyncQueryIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/async/AsyncQueryIT.java @@ -41,6 +41,7 @@ public class AsyncQueryIT { private AsyncSession session; @BeforeEach + @SuppressWarnings("resource") void setUp() { session = neo4j.driver().session(AsyncSession.class); } diff --git a/driver/src/test/java/org/neo4j/driver/integration/async/AsyncSessionIT.java b/driver/src/test/java/org/neo4j/driver/integration/async/AsyncSessionIT.java index 9155162808..26fe878b3f 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/async/AsyncSessionIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/async/AsyncSessionIT.java @@ -95,6 +95,7 @@ class AsyncSessionIT { private AsyncSession session; @BeforeEach + @SuppressWarnings("resource") void setUp() { session = neo4j.driver().session(AsyncSession.class); } @@ -199,6 +200,7 @@ void shouldAllowNestedQueries() { } @Test + @SuppressWarnings("resource") void shouldAllowMultipleAsyncRunsWithoutConsumingResults() { var queryCount = 13; var cursors = IntStream.range(0, queryCount) @@ -520,6 +522,7 @@ void shouldConsumeNonEmptyCursor() { @Test @DisabledOnNeo4jWith(BOLT_V3) + @SuppressWarnings("resource") void shouldRunAfterBeginTxFailureOnBookmark() { var illegalBookmark = InternalBookmark.parse("Illegal Bookmark"); session = neo4j.driver() @@ -535,6 +538,7 @@ var record = await(cursor.singleAsync()); } @Test + @SuppressWarnings("resource") void shouldNotBeginTxAfterBeginTxFailureOnBookmark() { var illegalBookmark = InternalBookmark.parse("Illegal Bookmark"); session = neo4j.driver() @@ -547,6 +551,7 @@ void shouldNotBeginTxAfterBeginTxFailureOnBookmark() { @Test @EnabledOnNeo4jWith(BOLT_V3) + @SuppressWarnings("resource") void shouldNotRunAfterBeginTxFailureOnBookmark() { var illegalBookmark = InternalBookmark.parse("Illegal Bookmark"); session = neo4j.driver() diff --git a/driver/src/test/java/org/neo4j/driver/integration/async/AsyncSessionServerRestartIT.java b/driver/src/test/java/org/neo4j/driver/integration/async/AsyncSessionServerRestartIT.java index 179f14c7dd..8aed728b82 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/async/AsyncSessionServerRestartIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/async/AsyncSessionServerRestartIT.java @@ -40,6 +40,7 @@ class AsyncSessionServerRestartIT { private AsyncSession session; @BeforeEach + @SuppressWarnings("resource") void setUp() { session = neo4j.driver().session(AsyncSession.class); } diff --git a/driver/src/test/java/org/neo4j/driver/integration/async/AsyncTransactionIT.java b/driver/src/test/java/org/neo4j/driver/integration/async/AsyncTransactionIT.java index 2a7ed030bf..73e81063af 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/async/AsyncTransactionIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/async/AsyncTransactionIT.java @@ -69,6 +69,7 @@ class AsyncTransactionIT { private AsyncSession session; @BeforeEach + @SuppressWarnings("resource") void setUp() { session = neo4j.driver().session(AsyncSession.class); } @@ -265,6 +266,7 @@ void shouldNotAllowNewQueriesAfterAnIncorrectQuery() { } @Test + @SuppressWarnings("resource") void shouldFailBoBeginTxWithInvalidBookmark() { var session = neo4j.driver() .session( diff --git a/driver/src/test/java/org/neo4j/driver/integration/reactive/InternalReactiveSessionIT.java b/driver/src/test/java/org/neo4j/driver/integration/reactive/InternalReactiveSessionIT.java index 06b0b5432c..d4c6cef63a 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/reactive/InternalReactiveSessionIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/reactive/InternalReactiveSessionIT.java @@ -47,6 +47,7 @@ class InternalReactiveSessionIT { private InternalReactiveSession session; @BeforeEach + @SuppressWarnings("resource") void setUp() { session = (InternalReactiveSession) neo4j.driver().session(ReactiveSession.class); } diff --git a/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveSessionIT.java b/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveSessionIT.java index 46159f6b43..fd15054ce7 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveSessionIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveSessionIT.java @@ -60,6 +60,7 @@ class ReactiveSessionIT { @ParameterizedTest @MethodSource("managedTransactionsReturningReactiveResultPublisher") + @SuppressWarnings("resource") void shouldErrorWhenReactiveResultIsReturned(Function> fn) { // GIVEN var session = neo4j.driver().session(ReactiveSession.class); diff --git a/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveStreamsSessionIT.java b/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveStreamsSessionIT.java index 77ba5dcf51..eb82c25484 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveStreamsSessionIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveStreamsSessionIT.java @@ -59,6 +59,7 @@ public class ReactiveStreamsSessionIT { @ParameterizedTest @MethodSource("managedTransactionsReturningReactiveResultPublisher") + @SuppressWarnings("resource") void shouldErrorWhenReactiveResultIsReturned(Function> fn) { // GIVEN var session = neo4j.driver().session(ReactiveSession.class); diff --git a/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveTransactionIT.java b/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveTransactionIT.java index dcc27b9731..9e1ff03c1e 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveTransactionIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/reactive/ReactiveTransactionIT.java @@ -41,6 +41,7 @@ class ReactiveTransactionIT { static final DatabaseExtension neo4j = new DatabaseExtension(); @Test + @SuppressWarnings("resource") void shouldPreventPullAfterTransactionTermination() { // Given var session = neo4j.driver().session(ReactiveSession.class); @@ -66,6 +67,7 @@ void shouldPreventPullAfterTransactionTermination() { } @Test + @SuppressWarnings("resource") void shouldPreventDiscardAfterTransactionTermination() { // Given var session = neo4j.driver().session(ReactiveSession.class); @@ -91,6 +93,7 @@ void shouldPreventDiscardAfterTransactionTermination() { } @Test + @SuppressWarnings("resource") void shouldPreventRunAfterTransactionTermination() { // Given var session = neo4j.driver().session(ReactiveSession.class); @@ -109,6 +112,7 @@ void shouldPreventRunAfterTransactionTermination() { } @Test + @SuppressWarnings("resource") void shouldPreventPullAfterDriverTransactionTermination() { // Given var session = neo4j.driver().session(ReactiveSession.class); @@ -132,6 +136,7 @@ void shouldPreventPullAfterDriverTransactionTermination() { } @Test + @SuppressWarnings("resource") void shouldPreventDiscardAfterDriverTransactionTermination() { // Given var session = neo4j.driver().session(ReactiveSession.class); @@ -155,6 +160,7 @@ void shouldPreventDiscardAfterDriverTransactionTermination() { } @Test + @SuppressWarnings("resource") void shouldPreventRunAfterDriverTransactionTermination() { // Given var session = neo4j.driver().session(ReactiveSession.class); @@ -175,6 +181,7 @@ void shouldPreventRunAfterDriverTransactionTermination() { } @Test + @SuppressWarnings("resource") void shouldTerminateTransactionAndHandleFailureResponseOrPreventFurtherPulls() { // Given var session = neo4j.driver().session(ReactiveSession.class); diff --git a/driver/src/test/java/org/neo4j/driver/integration/reactive/RxNestedQueriesIT.java b/driver/src/test/java/org/neo4j/driver/integration/reactive/RxNestedQueriesIT.java index 157b1a134b..221e77d750 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/reactive/RxNestedQueriesIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/reactive/RxNestedQueriesIT.java @@ -41,6 +41,7 @@ class RxNestedQueriesIT { static final DatabaseExtension neo4j = new DatabaseExtension(); @Test + @SuppressWarnings("resource") void shouldErrorForNestingQueriesAmongSessionRuns() { var size = 12555; @@ -65,6 +66,7 @@ void shouldErrorForNestingQueriesAmongSessionRuns() { } @Test + @SuppressWarnings("resource") void shouldErrorForNestingQueriesAmongTransactionFunctions() { var size = 12555; var nodeIds = Flux.usingWhen( @@ -88,6 +90,7 @@ void shouldErrorForNestingQueriesAmongTransactionFunctions() { } @Test + @SuppressWarnings("resource") void shouldErrorForNestingQueriesAmongSessionRunAndTransactionFunction() { var size = 12555; var nodeIds = Flux.usingWhen( @@ -111,6 +114,7 @@ void shouldErrorForNestingQueriesAmongSessionRunAndTransactionFunction() { } @Test + @SuppressWarnings("resource") void shouldErrorForNestingQueriesAmongTransactionFunctionAndSessionRun() { var size = 12555; var nodeIds = Flux.usingWhen( @@ -133,6 +137,7 @@ void shouldErrorForNestingQueriesAmongTransactionFunctionAndSessionRun() { } @Test + @SuppressWarnings("resource") void shouldHandleNestedQueriesInTheSameTransaction() { var size = 12555; diff --git a/driver/src/test/java/org/neo4j/driver/integration/reactive/RxResultIT.java b/driver/src/test/java/org/neo4j/driver/integration/reactive/RxResultIT.java index 4e72e76e5a..39716454fb 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/reactive/RxResultIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/reactive/RxResultIT.java @@ -61,6 +61,7 @@ void shouldAllowIteratingOverResultStream() { } @Test + @SuppressWarnings("resource") void shouldAllowIteratingOverLargeResultStream() { // When var size = 100000; @@ -135,6 +136,7 @@ void shouldAllowAccessKeysAndSummaryAfterRecord() { } @Test + @SuppressWarnings("resource") void shouldGiveHelpfulFailureMessageWhenAccessNonExistingField() { // Given var session = neo4j.driver().rxSession(); @@ -151,6 +153,7 @@ void shouldGiveHelpfulFailureMessageWhenAccessNonExistingField() { } @Test + @SuppressWarnings("resource") void shouldGiveHelpfulFailureMessageWhenAccessNonExistingPropertyOnNode() { // Given var session = neo4j.driver().rxSession(); @@ -167,6 +170,7 @@ void shouldGiveHelpfulFailureMessageWhenAccessNonExistingPropertyOnNode() { } @Test + @SuppressWarnings("resource") void shouldHaveFieldNamesInResult() { // When var session = neo4j.driver().rxSession(); @@ -184,6 +188,7 @@ void shouldHaveFieldNamesInResult() { } @Test + @SuppressWarnings("resource") void shouldReturnEmptyKeyAndRecordOnEmptyResult() { // Given var session = neo4j.driver().rxSession(); @@ -195,6 +200,7 @@ void shouldReturnEmptyKeyAndRecordOnEmptyResult() { } @Test + @SuppressWarnings("resource") void shouldOnlyErrorRecordAfterFailure() { // Given var session = neo4j.driver().rxSession(); @@ -224,6 +230,7 @@ void shouldOnlyErrorRecordAfterFailure() { } @Test + @SuppressWarnings("resource") void shouldErrorOnSummaryIfNoRecord() { // Given var session = neo4j.driver().rxSession(); @@ -253,6 +260,7 @@ void shouldErrorOnSummaryIfNoRecord() { } @Test + @SuppressWarnings("resource") void shouldDiscardRecords() { // Given var session = neo4j.driver().rxSession(); @@ -279,6 +287,7 @@ void shouldDiscardRecords() { } @Test + @SuppressWarnings("resource") void shouldStreamCorrectRecordsBackBeforeError() { var session = neo4j.driver().rxSession(); @@ -295,6 +304,7 @@ void shouldStreamCorrectRecordsBackBeforeError() { } @Test + @SuppressWarnings("resource") void shouldErrorToAccessRecordAfterSessionClose() { // Given var session = neo4j.driver().rxSession(); @@ -308,6 +318,7 @@ void shouldErrorToAccessRecordAfterSessionClose() { } @Test + @SuppressWarnings("resource") void shouldErrorToAccessKeysAfterSessionClose() { // Given var session = neo4j.driver().rxSession(); @@ -321,6 +332,7 @@ void shouldErrorToAccessKeysAfterSessionClose() { } @Test + @SuppressWarnings("resource") void shouldErrorToAccessSummaryAfterSessionClose() { // Given var session = neo4j.driver().rxSession(); @@ -334,6 +346,7 @@ void shouldErrorToAccessSummaryAfterSessionClose() { } @Test + @SuppressWarnings("resource") void shouldErrorToAccessRecordAfterTxClose() { // Given var session = neo4j.driver().rxSession(); @@ -350,6 +363,7 @@ void shouldErrorToAccessRecordAfterTxClose() { } @Test + @SuppressWarnings("resource") void shouldErrorToAccessKeysAfterTxClose() { // Given var session = neo4j.driver().rxSession(); @@ -366,6 +380,7 @@ void shouldErrorToAccessKeysAfterTxClose() { } @Test + @SuppressWarnings("resource") void shouldErrorToAccessSummaryAfterTxClose() { // Given var session = neo4j.driver().rxSession(); @@ -382,6 +397,7 @@ void shouldErrorToAccessSummaryAfterTxClose() { } @Test + @SuppressWarnings("resource") void throwErrorAfterKeys() { // Given var session = neo4j.driver().rxSession(); @@ -398,6 +414,7 @@ void throwErrorAfterKeys() { } @Test + @SuppressWarnings("resource") void throwTheSameErrorWhenCallingConsumeMultipleTimes() { // Given var session = neo4j.driver().rxSession(); @@ -414,6 +431,7 @@ void throwTheSameErrorWhenCallingConsumeMultipleTimes() { } @Test + @SuppressWarnings("resource") void keysShouldNotReportRunError() { // Given var session = neo4j.driver().rxSession(); @@ -429,6 +447,7 @@ void keysShouldNotReportRunError() { } @Test + @SuppressWarnings("resource") void throwResultConsumedErrorWhenCallingRecordsMultipleTimes() { // Given var session = neo4j.driver().rxSession(); @@ -474,6 +493,7 @@ private void verifyCanAccessKeys(RxResult res) { StepVerifier.create(res.keys()).expectNext(singletonList("a")).verifyComplete(); } + @SuppressWarnings("resource") private RxResult sessionRunUnwind() { var session = neo4j.driver().rxSession(); return session.run("UNWIND [1,2,3,4] AS a RETURN a"); diff --git a/driver/src/test/java/org/neo4j/driver/integration/reactive/RxSessionIT.java b/driver/src/test/java/org/neo4j/driver/integration/reactive/RxSessionIT.java index 60f0ded0a9..bea13540c9 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/reactive/RxSessionIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/reactive/RxSessionIT.java @@ -61,6 +61,7 @@ class RxSessionIT { static final DatabaseExtension neo4j = new DatabaseExtension(); @Test + @SuppressWarnings("resource") void shouldAllowSessionRun() { // When var session = neo4j.driver().rxSession(); @@ -77,6 +78,7 @@ void shouldAllowSessionRun() { } @Test + @SuppressWarnings("resource") void shouldBeAbleToReuseSessionAfterFailure() { // Given var session = neo4j.driver().rxSession(); @@ -95,6 +97,7 @@ void shouldBeAbleToReuseSessionAfterFailure() { } @Test + @SuppressWarnings("resource") void shouldRunAsyncTransactionWithoutRetries() { var session = neo4j.driver().rxSession(); var work = new InvocationTrackingWork("CREATE (:Apa) RETURN 42"); @@ -107,6 +110,7 @@ void shouldRunAsyncTransactionWithoutRetries() { } @Test + @SuppressWarnings("resource") void shouldRunAsyncTransactionWithRetriesOnAsyncFailures() { var session = neo4j.driver().rxSession(); var work = new InvocationTrackingWork("CREATE (:Node) RETURN 24") @@ -124,6 +128,7 @@ void shouldRunAsyncTransactionWithRetriesOnAsyncFailures() { } @Test + @SuppressWarnings("resource") void shouldRunAsyncTransactionWithRetriesOnSyncFailures() { var session = neo4j.driver().rxSession(); var work = new InvocationTrackingWork("CREATE (:Test) RETURN 12") @@ -140,6 +145,7 @@ void shouldRunAsyncTransactionWithRetriesOnSyncFailures() { } @Test + @SuppressWarnings("resource") void shouldRunAsyncTransactionThatCanNotBeRetried() { var session = neo4j.driver().rxSession(); var work = new InvocationTrackingWork("UNWIND [10, 5, 0] AS x CREATE (:Hi) RETURN 10/x"); @@ -157,6 +163,7 @@ void shouldRunAsyncTransactionThatCanNotBeRetried() { } @Test + @SuppressWarnings("resource") void shouldRunAsyncTransactionThatCanNotBeRetriedAfterATransientFailure() { var session = neo4j.driver().rxSession(); // first throw TransientException directly from work, retry can happen afterwards @@ -181,6 +188,7 @@ void shouldRunAsyncTransactionThatCanNotBeRetriedAfterATransientFailure() { @ParameterizedTest @MethodSource("managedTransactionsReturningReactiveResultPublisher") + @SuppressWarnings("resource") void shouldErrorWhenReactiveResultIsReturned(Function> fn) { // GIVEN var session = neo4j.driver().rxSession(); @@ -209,6 +217,7 @@ private void assertNoParallelScheduler() { } } + @SuppressWarnings("resource") private long countNodesByLabel(String label) { try (var session = neo4j.driver().session()) { var result = session.run("MATCH (n:" + label + ") RETURN count(n)"); diff --git a/driver/src/test/java/org/neo4j/driver/integration/reactive/RxTransactionIT.java b/driver/src/test/java/org/neo4j/driver/integration/reactive/RxTransactionIT.java index b4618c4f8e..ec074c67e9 100644 --- a/driver/src/test/java/org/neo4j/driver/integration/reactive/RxTransactionIT.java +++ b/driver/src/test/java/org/neo4j/driver/integration/reactive/RxTransactionIT.java @@ -78,6 +78,7 @@ class RxTransactionIT { private RxSession session; @BeforeEach + @SuppressWarnings("resource") void setUp() { session = neo4j.driver().rxSession(); } @@ -262,6 +263,7 @@ void shouldNotAllowNewQueriesAfterAnIncorrectQuery() { } @Test + @SuppressWarnings("resource") void shouldFailBoBeginTxWithInvalidBookmark() { var session = neo4j.driver() .rxSession(builder().withBookmarks(parse("InvalidBookmark")).build()); diff --git a/driver/src/test/java/org/neo4j/driver/internal/CustomSecurityPlanTest.java b/driver/src/test/java/org/neo4j/driver/internal/CustomSecurityPlanTest.java index 00e42a6995..a350bdc088 100644 --- a/driver/src/test/java/org/neo4j/driver/internal/CustomSecurityPlanTest.java +++ b/driver/src/test/java/org/neo4j/driver/internal/CustomSecurityPlanTest.java @@ -38,6 +38,7 @@ class CustomSecurityPlanTest { @Test + @SuppressWarnings("resource") void testCustomSecurityPlanUsed() { var driverFactory = new SecurityPlanCapturingDriverFactory(); diff --git a/driver/src/test/java/org/neo4j/driver/internal/DelegatingTransactionContextTest.java b/driver/src/test/java/org/neo4j/driver/internal/DelegatingTransactionContextTest.java index fd23dc4067..c722d13db0 100644 --- a/driver/src/test/java/org/neo4j/driver/internal/DelegatingTransactionContextTest.java +++ b/driver/src/test/java/org/neo4j/driver/internal/DelegatingTransactionContextTest.java @@ -44,6 +44,7 @@ void beforeEach() { } @Test + @SuppressWarnings("resource") void shouldDelegateRunWithValueParams() { // GIVEN var query = "something"; @@ -60,6 +61,7 @@ void shouldDelegateRunWithValueParams() { } @Test + @SuppressWarnings("resource") void shouldDelegateRunWithMapParams() { // GIVEN var query = "something"; @@ -76,6 +78,7 @@ void shouldDelegateRunWithMapParams() { } @Test + @SuppressWarnings("resource") void shouldDelegateRunWithRecordParams() { // GIVEN var query = "something"; @@ -92,6 +95,7 @@ void shouldDelegateRunWithRecordParams() { } @Test + @SuppressWarnings("resource") void shouldDelegateRun() { // GIVEN var query = "something"; @@ -107,6 +111,7 @@ void shouldDelegateRun() { } @Test + @SuppressWarnings("resource") void shouldDelegateRunWithQueryType() { // GIVEN var query = mock(Query.class); diff --git a/driver/src/test/java/org/neo4j/driver/internal/DriverFactoryTest.java b/driver/src/test/java/org/neo4j/driver/internal/DriverFactoryTest.java index 86338d74f1..bca583f539 100644 --- a/driver/src/test/java/org/neo4j/driver/internal/DriverFactoryTest.java +++ b/driver/src/test/java/org/neo4j/driver/internal/DriverFactoryTest.java @@ -85,6 +85,7 @@ private static Stream testUris() { @ParameterizedTest @MethodSource("testUris") + @SuppressWarnings("resource") void connectionPoolClosedWhenDriverCreationFails(String uri) { var connectionPool = connectionPoolMock(); DriverFactory factory = new ThrowingDriverFactory(connectionPool); @@ -95,6 +96,7 @@ void connectionPoolClosedWhenDriverCreationFails(String uri) { @ParameterizedTest @MethodSource("testUris") + @SuppressWarnings("resource") void connectionPoolCloseExceptionIsSuppressedWhenDriverCreationFails(String uri) { var connectionPool = connectionPoolMock(); var poolCloseError = new RuntimeException("Pool close error"); @@ -109,6 +111,7 @@ void connectionPoolCloseExceptionIsSuppressedWhenDriverCreationFails(String uri) @ParameterizedTest @MethodSource("testUris") + @SuppressWarnings("resource") void usesStandardSessionFactoryWhenNothingConfigured(String uri) { var config = defaultConfig(); var factory = new SessionFactoryCapturingDriverFactory(); @@ -121,6 +124,7 @@ void usesStandardSessionFactoryWhenNothingConfigured(String uri) { @ParameterizedTest @MethodSource("testUris") + @SuppressWarnings("resource") void usesLeakLoggingSessionFactoryWhenConfigured(String uri) { var config = Config.builder().withLeakedSessionsLogging().build(); var factory = new SessionFactoryCapturingDriverFactory(); @@ -198,6 +202,7 @@ void shouldCreateAppropriateDriverType(String uri) { } @Test + @SuppressWarnings("resource") void shouldUseBuiltInRediscoveryByDefault() { // GIVEN var driverFactory = new DriverFactory(); @@ -219,6 +224,7 @@ void shouldUseBuiltInRediscoveryByDefault() { } @Test + @SuppressWarnings("resource") void shouldUseSuppliedRediscovery() { // GIVEN var driverFactory = new DriverFactory(); diff --git a/driver/src/test/java/org/neo4j/driver/internal/InternalDriverTest.java b/driver/src/test/java/org/neo4j/driver/internal/InternalDriverTest.java index a2bfbbe029..86b613a0e7 100644 --- a/driver/src/test/java/org/neo4j/driver/internal/InternalDriverTest.java +++ b/driver/src/test/java/org/neo4j/driver/internal/InternalDriverTest.java @@ -65,6 +65,7 @@ void shouldNotCloseSessionFactoryMultipleTimes() { } @Test + @SuppressWarnings("resource") void shouldVerifyConnectivity() { var sessionFactory = sessionFactoryMock(); CompletableFuture connectivityStage = completedWithNull(); @@ -76,6 +77,7 @@ void shouldVerifyConnectivity() { } @Test + @SuppressWarnings("resource") void shouldThrowWhenUnableToVerifyConnectivity() { var sessionFactory = mock(SessionFactory.class); var error = new ServiceUnavailableException("Hello"); @@ -87,6 +89,7 @@ void shouldThrowWhenUnableToVerifyConnectivity() { } @Test + @SuppressWarnings("resource") void shouldThrowClientExceptionIfMetricsNotEnabled() { // Given var driver = newDriver(false); @@ -99,6 +102,7 @@ void shouldThrowClientExceptionIfMetricsNotEnabled() { } @Test + @SuppressWarnings("resource") void shouldReturnMetricsIfMetricsEnabled() { // Given var driver = newDriver(true); diff --git a/driver/src/test/java/org/neo4j/driver/internal/InternalExecutableQueryTest.java b/driver/src/test/java/org/neo4j/driver/internal/InternalExecutableQueryTest.java index 940c914a68..4b6fdaac3a 100644 --- a/driver/src/test/java/org/neo4j/driver/internal/InternalExecutableQueryTest.java +++ b/driver/src/test/java/org/neo4j/driver/internal/InternalExecutableQueryTest.java @@ -120,7 +120,7 @@ static List routingControls() { @ParameterizedTest @MethodSource("routingControls") - @SuppressWarnings("unchecked") + @SuppressWarnings({"unchecked", "resource"}) void shouldExecuteAndReturnResult(RoutingControl routingControl) { // GIVEN var driver = mock(Driver.class); diff --git a/driver/src/test/java/org/neo4j/driver/internal/InternalTransactionTest.java b/driver/src/test/java/org/neo4j/driver/internal/InternalTransactionTest.java index 4bdcc6f412..6d8b0582c2 100644 --- a/driver/src/test/java/org/neo4j/driver/internal/InternalTransactionTest.java +++ b/driver/src/test/java/org/neo4j/driver/internal/InternalTransactionTest.java @@ -61,6 +61,7 @@ class InternalTransactionTest { private Transaction tx; @BeforeEach + @SuppressWarnings("resource") void setUp() { connection = connectionMock(BoltProtocolV4.INSTANCE); var connectionProvider = mock(ConnectionProvider.class); diff --git a/driver/src/test/java/org/neo4j/driver/internal/cluster/loadbalancing/LeastConnectedLoadBalancingStrategyTest.java b/driver/src/test/java/org/neo4j/driver/internal/cluster/loadbalancing/LeastConnectedLoadBalancingStrategyTest.java index 22dcbc668a..bc1f8f1364 100644 --- a/driver/src/test/java/org/neo4j/driver/internal/cluster/loadbalancing/LeastConnectedLoadBalancingStrategyTest.java +++ b/driver/src/test/java/org/neo4j/driver/internal/cluster/loadbalancing/LeastConnectedLoadBalancingStrategyTest.java @@ -47,6 +47,7 @@ class LeastConnectedLoadBalancingStrategyTest { private LeastConnectedLoadBalancingStrategy strategy; @BeforeEach + @SuppressWarnings("resource") void setUp() { openMocks(this); strategy = new LeastConnectedLoadBalancingStrategy(connectionPool, DEV_NULL_LOGGING); diff --git a/driver/src/test/java/org/neo4j/driver/internal/util/Neo4jWithFeatureCondition.java b/driver/src/test/java/org/neo4j/driver/internal/util/Neo4jWithFeatureCondition.java index ef433f4316..e38fd03cd0 100644 --- a/driver/src/test/java/org/neo4j/driver/internal/util/Neo4jWithFeatureCondition.java +++ b/driver/src/test/java/org/neo4j/driver/internal/util/Neo4jWithFeatureCondition.java @@ -56,6 +56,7 @@ public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext con return ENABLED_NOT_ANNOTATED; } + @SuppressWarnings("resource") private static ConditionEvaluationResult checkFeatureAvailability(Neo4jFeature feature, boolean negated) { var driver = DatabaseExtension.getInstance().driver(); if (driver != null) { @@ -77,6 +78,7 @@ private static ConditionEvaluationResult checkFeatureAvailability(Neo4jFeature f return ENABLED_UNKNOWN_DB_VERSION; } + @SuppressWarnings("resource") private static ConditionEvaluationResult checkEditionAvailability( ConditionEvaluationResult previousResult, Neo4jEdition edition) { if (previousResult.isDisabled()) { diff --git a/driver/src/test/java/org/neo4j/driver/internal/value/UnsupportedDateTimeValueTest.java b/driver/src/test/java/org/neo4j/driver/internal/value/UnsupportedDateTimeValueTest.java index 5a088c0f69..a9addaca16 100644 --- a/driver/src/test/java/org/neo4j/driver/internal/value/UnsupportedDateTimeValueTest.java +++ b/driver/src/test/java/org/neo4j/driver/internal/value/UnsupportedDateTimeValueTest.java @@ -43,6 +43,7 @@ public class UnsupportedDateTimeValueTest { private DateTimeException exception; @BeforeEach + @SuppressWarnings("resource") void beforeEach() { openMocks(this); } diff --git a/driver/src/test/java/org/neo4j/driver/tck/reactive/Neo4jManager.java b/driver/src/test/java/org/neo4j/driver/tck/reactive/Neo4jManager.java index 09438ac847..12b66e81f8 100644 --- a/driver/src/test/java/org/neo4j/driver/tck/reactive/Neo4jManager.java +++ b/driver/src/test/java/org/neo4j/driver/tck/reactive/Neo4jManager.java @@ -24,6 +24,7 @@ import org.testng.SkipException; public class Neo4jManager { + @SuppressWarnings("resource") private final Neo4jContainer NEO4J = new Neo4jContainer<>("neo4j:4.4").withAdminPassword(null); public void start() { diff --git a/driver/src/test/java/org/neo4j/driver/testutil/DatabaseExtension.java b/driver/src/test/java/org/neo4j/driver/testutil/DatabaseExtension.java index 9a56e9ea1d..579f0dc2e0 100644 --- a/driver/src/test/java/org/neo4j/driver/testutil/DatabaseExtension.java +++ b/driver/src/test/java/org/neo4j/driver/testutil/DatabaseExtension.java @@ -284,6 +284,7 @@ private static CertificateKeyPair generateCertificateAndKey() { } } + @SuppressWarnings("resource") private static Neo4jContainer setupNeo4jContainer(File cert, File key, Map config) { var neo4JVersion = Optional.ofNullable(System.getenv("NEO4J_VERSION")).orElse("4.4"); @@ -310,7 +311,7 @@ private static Neo4jContainer setupNeo4jContainer(File cert, File key, Map setupNginxContainer() { var extendedNginxImage = new ImageFromDockerfile() .withDockerfileFromBuilder(builder -> builder.from("nginx:1.23.0-alpine") @@ -346,6 +347,7 @@ private static void waitForBoltAvailability() { } } + @SuppressWarnings("resource") private static boolean isDockerAvailable() { try { DockerClientFactory.instance().client(); diff --git a/driver/src/test/java/org/neo4j/driver/testutil/DriverExtension.java b/driver/src/test/java/org/neo4j/driver/testutil/DriverExtension.java index 4e09ae7536..c62c04d698 100644 --- a/driver/src/test/java/org/neo4j/driver/testutil/DriverExtension.java +++ b/driver/src/test/java/org/neo4j/driver/testutil/DriverExtension.java @@ -43,6 +43,7 @@ public Session session() { } @Override + @SuppressWarnings("resource") public void beforeEach(ExtensionContext context) throws Exception { super.beforeEach(context); asyncSession = driver().session(AsyncSession.class); diff --git a/driver/src/test/java/org/neo4j/driver/testutil/SessionExtension.java b/driver/src/test/java/org/neo4j/driver/testutil/SessionExtension.java index 9435ce6010..3ae4ef1348 100644 --- a/driver/src/test/java/org/neo4j/driver/testutil/SessionExtension.java +++ b/driver/src/test/java/org/neo4j/driver/testutil/SessionExtension.java @@ -45,6 +45,7 @@ public class SessionExtension extends DatabaseExtension implements Session, Befo private Session realSession; @Override + @SuppressWarnings("resource") public void beforeEach(ExtensionContext context) throws Exception { super.beforeEach(context); realSession = driver().session(); diff --git a/driver/src/test/java/org/neo4j/driver/testutil/cc/LocalOrRemoteClusterExtension.java b/driver/src/test/java/org/neo4j/driver/testutil/cc/LocalOrRemoteClusterExtension.java index 15cea63c57..9933ead224 100644 --- a/driver/src/test/java/org/neo4j/driver/testutil/cc/LocalOrRemoteClusterExtension.java +++ b/driver/src/test/java/org/neo4j/driver/testutil/cc/LocalOrRemoteClusterExtension.java @@ -55,6 +55,7 @@ public AuthTokenManager getAuthToken() { } @Override + @SuppressWarnings("resource") public void beforeAll(ExtensionContext context) { if (remoteClusterExists()) { clusterUri = remoteClusterUriFromSystemProperty();