From d621df460e8b5d75bb3aee5b011470edf5a4b007 Mon Sep 17 00:00:00 2001 From: lutovich Date: Tue, 24 Apr 2018 15:48:09 +0200 Subject: [PATCH] Log driver's hashCode during startup and shutdown Previously, driver logged its fully qualified class name and hash code when created or closed. Example: ``` Direct driver instance o.n.d.i.InternalDriver@30316b44 created for server address localhost:7687 Closing driver instance o.n.d.i.InternalDriver@30316b44 ``` Class name does not seem to be useful and this commit replaces it with logging of the hash code. Example: ``` Direct driver instance 808545092 created for server address localhost:7687 Closing driver instance 808545092 ``` --- .../main/java/org/neo4j/driver/internal/DriverFactory.java | 6 +++--- .../main/java/org/neo4j/driver/internal/InternalDriver.java | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java b/driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java index 3283a21327..30cc3f9755 100644 --- a/driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java +++ b/driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java @@ -38,9 +38,9 @@ import org.neo4j.driver.internal.cluster.loadbalancing.LoadBalancingStrategy; import org.neo4j.driver.internal.cluster.loadbalancing.RoundRobinLoadBalancingStrategy; import org.neo4j.driver.internal.logging.NettyLogging; -import org.neo4j.driver.internal.metrics.MetricsListener; import org.neo4j.driver.internal.metrics.InternalAbstractMetrics; import org.neo4j.driver.internal.metrics.InternalMetrics; +import org.neo4j.driver.internal.metrics.MetricsListener; import org.neo4j.driver.internal.metrics.spi.Metrics; import org.neo4j.driver.internal.retry.ExponentialBackoffRetryLogic; import org.neo4j.driver.internal.retry.RetryLogic; @@ -160,7 +160,7 @@ protected InternalDriver createDirectDriver( SecurityPlan securityPlan, BoltServ SessionFactory sessionFactory = createSessionFactory( connectionProvider, retryLogic, config ); InternalDriver driver = createDriver(securityPlan, sessionFactory, metrics, config); Logger log = config.logging().getLog( Driver.class.getSimpleName() ); - log.info( "Direct driver instance %s created for server address %s", driver, address.toString() ); + log.info( "Direct driver instance %s created for server address %s", driver.hashCode(), address ); return driver; } @@ -181,7 +181,7 @@ protected InternalDriver createRoutingDriver( SecurityPlan securityPlan, BoltSer SessionFactory sessionFactory = createSessionFactory( connectionProvider, retryLogic, config ); InternalDriver driver = createDriver(securityPlan, sessionFactory, metrics, config); Logger log = config.logging().getLog( Driver.class.getSimpleName() ); - log.info( "Routing driver instance %s created for server address %s", driver, address.toString() ); + log.info( "Routing driver instance %s created for server address %s", driver.hashCode(), address ); return driver; } diff --git a/driver/src/main/java/org/neo4j/driver/internal/InternalDriver.java b/driver/src/main/java/org/neo4j/driver/internal/InternalDriver.java index 3e0cc92de0..189b0e6309 100644 --- a/driver/src/main/java/org/neo4j/driver/internal/InternalDriver.java +++ b/driver/src/main/java/org/neo4j/driver/internal/InternalDriver.java @@ -115,7 +115,7 @@ public CompletionStage closeAsync() { if ( closed.compareAndSet( false, true ) ) { - log.info( "Closing driver instance %s", this ); + log.info( "Closing driver instance %s", hashCode() ); return sessionFactory.close(); } return completedWithNull();