From 00dc32be00099502aa5f96a61c7c163f8b00a0d7 Mon Sep 17 00:00:00 2001 From: MaxAake <61233757+MaxAake@users.noreply.github.com> Date: Tue, 25 Feb 2025 09:21:27 +0100 Subject: [PATCH 1/4] skip tests on rx --- packages/testkit-backend/src/skipped-tests/rx.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/testkit-backend/src/skipped-tests/rx.js b/packages/testkit-backend/src/skipped-tests/rx.js index 558e17f4e..c6fe4c843 100644 --- a/packages/testkit-backend/src/skipped-tests/rx.js +++ b/packages/testkit-backend/src/skipped-tests/rx.js @@ -1,9 +1,13 @@ -import { skip, ifEquals } from './skip.js' +import { skip, ifEquals, ifStartsWith } from './skip.js' const skippedTests = [ skip( 'Throws after run insted of the first next because of the backend implementation', ifEquals('stub.disconnects.test_disconnects.TestDisconnects.test_disconnect_on_tx_begin') + ), + skip( + 'Reactive driver does not send DISCARD on consume if records stream has been subscribed to', + ifStartsWith('stub.summary.test_summary') ) ] From 48666ba4104d8ac0826cc3ba6a07a5ac8dfdc5a7 Mon Sep 17 00:00:00 2001 From: MaxAake <61233757+MaxAake@users.noreply.github.com> Date: Tue, 25 Feb 2025 09:26:30 +0100 Subject: [PATCH 2/4] switch TK branch --- testkit/testkit.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testkit/testkit.json b/testkit/testkit.json index 931900356..b80791755 100644 --- a/testkit/testkit.json +++ b/testkit/testkit.json @@ -1,6 +1,6 @@ { "testkit": { "uri": "https://github.com/neo4j-drivers/testkit.git", - "ref": "5.0" + "ref": "summary-test-discard-and-pull" } } From 06e35b986dd72056234624d12a95fd4e6c3c4b4f Mon Sep 17 00:00:00 2001 From: MaxAake <61233757+MaxAake@users.noreply.github.com> Date: Tue, 25 Feb 2025 14:09:28 +0100 Subject: [PATCH 3/4] more precise skipping --- packages/testkit-backend/src/skipped-tests/rx.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/testkit-backend/src/skipped-tests/rx.js b/packages/testkit-backend/src/skipped-tests/rx.js index c6fe4c843..077a5c374 100644 --- a/packages/testkit-backend/src/skipped-tests/rx.js +++ b/packages/testkit-backend/src/skipped-tests/rx.js @@ -7,7 +7,13 @@ const skippedTests = [ ), skip( 'Reactive driver does not send DISCARD on consume if records stream has been subscribed to', - ifStartsWith('stub.summary.test_summary') + ifStartsWith('stub.summary.test_summary.TestSummaryPlanDiscard'), + ifStartsWith('stub.summary.test_summary.TestSummaryCountersDiscard'), + ifStartsWith('stub.summary.test_summary.TestSummaryBasicInfoDiscard'), + ifStartsWith('stub.summary.test_summary.TestSummaryGqlStatusObjects4x4Discard'), + ifStartsWith('stub.summary.test_summary.TestSummaryGqlStatusObjects5x6Discard'), + ifStartsWith('stub.summary.test_summary.TestSummaryNotifications4x4Discard'), + ifStartsWith('stub.summary.test_summary.TestSummaryNotifications5x6Discard') ) ] From 706592ca43387b73fe31d0a1a8aafd53cd2123d0 Mon Sep 17 00:00:00 2001 From: MaxAake <61233757+MaxAake@users.noreply.github.com> Date: Tue, 25 Feb 2025 16:00:51 +0100 Subject: [PATCH 4/4] revert to 5.0 testkit --- testkit/testkit.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testkit/testkit.json b/testkit/testkit.json index b80791755..931900356 100644 --- a/testkit/testkit.json +++ b/testkit/testkit.json @@ -1,6 +1,6 @@ { "testkit": { "uri": "https://github.com/neo4j-drivers/testkit.git", - "ref": "summary-test-discard-and-pull" + "ref": "5.0" } }