diff --git a/packages/core/src/session.ts b/packages/core/src/session.ts index 13aa4fddf..df3e6dc1b 100644 --- a/packages/core/src/session.ts +++ b/packages/core/src/session.ts @@ -362,18 +362,6 @@ class Session { this._hasTx = false } - /** - * Return the bookmarks received following the last completed {@link Transaction}. - * - * @deprecated This method will be removed in version 6.0. Please, use {@link Session#lastBookmarks} instead. - * - * @return {string[]} A reference to a previous transaction. - * @see {@link Session#lastBookmarks} - */ - lastBookmark (): string[] { - return this.lastBookmarks() - } - /** * Return the bookmarks received following the last completed {@link Transaction}. * diff --git a/packages/core/test/session.test.ts b/packages/core/test/session.test.ts index b0b2b1180..3824dbfe3 100644 --- a/packages/core/test/session.test.ts +++ b/packages/core/test/session.test.ts @@ -268,19 +268,7 @@ describe('session', () => { }) }) - describe('.lastBookmark()', () => { - it.each([ - [bookmarks.Bookmarks.empty()], - [new bookmarks.Bookmarks('bookmark1')], - [new bookmarks.Bookmarks(['bookmark1', 'bookmark2'])] - ])('should return the bookmark informed in the object creation', (bookmarks) => { - const session = newSessionWithConnection(newFakeConnection(), false, 1000, bookmarks) - - expect(session.lastBookmark()).toEqual(bookmarks.values()) - }) - }) - - describe('.lastBookmark()', () => { + describe('.lastBookmarks()', () => { it.each([ [bookmarks.Bookmarks.empty()], [new bookmarks.Bookmarks('bookmark1')], diff --git a/packages/neo4j-driver-deno/lib/core/session.ts b/packages/neo4j-driver-deno/lib/core/session.ts index 943d90aaf..1af4f8dea 100644 --- a/packages/neo4j-driver-deno/lib/core/session.ts +++ b/packages/neo4j-driver-deno/lib/core/session.ts @@ -362,18 +362,6 @@ class Session { this._hasTx = false } - /** - * Return the bookmarks received following the last completed {@link Transaction}. - * - * @deprecated This method will be removed in version 6.0. Please, use {@link Session#lastBookmarks} instead. - * - * @return {string[]} A reference to a previous transaction. - * @see {@link Session#lastBookmarks} - */ - lastBookmark (): string[] { - return this.lastBookmarks() - } - /** * Return the bookmarks received following the last completed {@link Transaction}. * diff --git a/packages/neo4j-driver/src/session-rx.js b/packages/neo4j-driver/src/session-rx.js index ba61b0445..f56a6e236 100644 --- a/packages/neo4j-driver/src/session-rx.js +++ b/packages/neo4j-driver/src/session-rx.js @@ -139,23 +139,6 @@ export default class RxSession { return this.close() } - /** - * Returns the bookmarks received following the last successfully completed query, which is executed - * either in an {@link RxTransaction} obtained from this session instance or directly through one of - * the {@link RxSession#run} method of this session instance. - * - * If no bookmarks were received or if this transaction was rolled back, the bookmarks value will not be - * changed. - * - * @deprecated This method will be removed in 6.0 version. Please, use {@link RxSession#lastBookmarks} instead. - * - * @public - * @returns {string[]} - */ - lastBookmark () { - return this.lastBookmarks() - } - /** * Returns the bookmarks received following the last successfully completed query, which is executed * either in an {@link RxTransaction} obtained from this session instance or directly through one of diff --git a/packages/neo4j-driver/test/rx/session.test.js b/packages/neo4j-driver/test/rx/session.test.js index fbd40bdc6..d74915711 100644 --- a/packages/neo4j-driver/test/rx/session.test.js +++ b/packages/neo4j-driver/test/rx/session.test.js @@ -414,19 +414,6 @@ describe('#integration rx-session', () => { }) describe('#unit rx-session', () => { - describe('lastBookmark', () => { - ;[ - bookmarks.Bookmarks.empty(), - new bookmarks.Bookmarks('bookmark1'), - new bookmarks.Bookmarks(['bookmark1', 'bookmark2']) - ].forEach(bookmarks => { - it(`should return ${bookmarks}`, () => { - const session = newSession(bookmarks) - expect(session.lastBookmark()).toBe(bookmarks.values()) - }) - }) - }) - describe('lastBookmarks', () => { ;[ bookmarks.Bookmarks.empty(), diff --git a/packages/neo4j-driver/test/types/session-rx.test.ts b/packages/neo4j-driver/test/types/session-rx.test.ts index b54bab8a7..bc4651d40 100644 --- a/packages/neo4j-driver/test/types/session-rx.test.ts +++ b/packages/neo4j-driver/test/types/session-rx.test.ts @@ -81,7 +81,6 @@ const txConfig7: TransactionConfig = { const tx1: Observable = rxSession.beginTransaction() const bookmarks: string[] = rxSession.lastBookmarks() -const bookmark: string[] = rxSession.lastBookmark() const observable1: Observable = rxSession.executeRead( (tx: RxTransaction) => {