Skip to content

Remove Deprecated lastBookmark() #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Remove Deprecated lastBookmark() #1316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/core/src/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,18 +362,6 @@ class Session {
this._hasTx = false
}

/**
* Return the bookmarks received following the last completed {@link Transaction}.
*
* @deprecated This method will be removed in version 6.0. Please, use {@link Session#lastBookmarks} instead.
*
* @return {string[]} A reference to a previous transaction.
* @see {@link Session#lastBookmarks}
*/
lastBookmark (): string[] {
return this.lastBookmarks()
}

/**
* Return the bookmarks received following the last completed {@link Transaction}.
*
Expand Down
14 changes: 1 addition & 13 deletions packages/core/test/session.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,19 +268,7 @@ describe('session', () => {
})
})

describe('.lastBookmark()', () => {
it.each([
[bookmarks.Bookmarks.empty()],
[new bookmarks.Bookmarks('bookmark1')],
[new bookmarks.Bookmarks(['bookmark1', 'bookmark2'])]
])('should return the bookmark informed in the object creation', (bookmarks) => {
const session = newSessionWithConnection(newFakeConnection(), false, 1000, bookmarks)

expect(session.lastBookmark()).toEqual(bookmarks.values())
})
})

describe('.lastBookmark()', () => {
describe('.lastBookmarks()', () => {
it.each([
[bookmarks.Bookmarks.empty()],
[new bookmarks.Bookmarks('bookmark1')],
Expand Down
12 changes: 0 additions & 12 deletions packages/neo4j-driver-deno/lib/core/session.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 0 additions & 17 deletions packages/neo4j-driver/src/session-rx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,23 +139,6 @@ export default class RxSession {
return this.close()
}

/**
* Returns the bookmarks received following the last successfully completed query, which is executed
* either in an {@link RxTransaction} obtained from this session instance or directly through one of
* the {@link RxSession#run} method of this session instance.
*
* If no bookmarks were received or if this transaction was rolled back, the bookmarks value will not be
* changed.
*
* @deprecated This method will be removed in 6.0 version. Please, use {@link RxSession#lastBookmarks} instead.
*
* @public
* @returns {string[]}
*/
lastBookmark () {
return this.lastBookmarks()
}

/**
* Returns the bookmarks received following the last successfully completed query, which is executed
* either in an {@link RxTransaction} obtained from this session instance or directly through one of
Expand Down
13 changes: 0 additions & 13 deletions packages/neo4j-driver/test/rx/session.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,19 +414,6 @@ describe('#integration rx-session', () => {
})

describe('#unit rx-session', () => {
describe('lastBookmark', () => {
;[
bookmarks.Bookmarks.empty(),
new bookmarks.Bookmarks('bookmark1'),
new bookmarks.Bookmarks(['bookmark1', 'bookmark2'])
].forEach(bookmarks => {
it(`should return ${bookmarks}`, () => {
const session = newSession(bookmarks)
expect(session.lastBookmark()).toBe(bookmarks.values())
})
})
})

describe('lastBookmarks', () => {
;[
bookmarks.Bookmarks.empty(),
Expand Down
1 change: 0 additions & 1 deletion packages/neo4j-driver/test/types/session-rx.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ const txConfig7: TransactionConfig = {

const tx1: Observable<RxTransaction> = rxSession.beginTransaction()
const bookmarks: string[] = rxSession.lastBookmarks()
const bookmark: string[] = rxSession.lastBookmark()

const observable1: Observable<number> = rxSession.executeRead(
(tx: RxTransaction) => {
Expand Down