From ffe1f6d37c331a560a9c00ec1627c0c5c99b629b Mon Sep 17 00:00:00 2001 From: ci <61233757+MaxAake@users.noreply.github.com> Date: Mon, 15 Sep 2025 15:37:47 +0200 Subject: [PATCH 1/2] handle getting a non-neo4j error --- .../src/connection-provider/connection-provider-routing.js | 2 +- .../connection-provider/connection-provider-routing.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/bolt-connection/src/connection-provider/connection-provider-routing.js b/packages/bolt-connection/src/connection-provider/connection-provider-routing.js index e69ce764b..74714ece8 100644 --- a/packages/bolt-connection/src/connection-provider/connection-provider-routing.js +++ b/packages/bolt-connection/src/connection-provider/connection-provider-routing.js @@ -817,7 +817,7 @@ function _isFailFastError (error) { } function _isFailFastSecurityError (error) { - return error.code.startsWith('Neo.ClientError.Security.') && + return error.code?.startsWith('Neo.ClientError.Security.') && ![ AUTHORIZATION_EXPIRED_CODE ].includes(error.code) diff --git a/packages/neo4j-driver-deno/lib/bolt-connection/connection-provider/connection-provider-routing.js b/packages/neo4j-driver-deno/lib/bolt-connection/connection-provider/connection-provider-routing.js index 1fc1e8639..79c25160d 100644 --- a/packages/neo4j-driver-deno/lib/bolt-connection/connection-provider/connection-provider-routing.js +++ b/packages/neo4j-driver-deno/lib/bolt-connection/connection-provider/connection-provider-routing.js @@ -817,7 +817,7 @@ function _isFailFastError (error) { } function _isFailFastSecurityError (error) { - return error.code.startsWith('Neo.ClientError.Security.') && + return error.code?.startsWith('Neo.ClientError.Security.') && ![ AUTHORIZATION_EXPIRED_CODE ].includes(error.code) From 76998adef8749fe9e6bbcb1df27d5c4dd10e2bb9 Mon Sep 17 00:00:00 2001 From: ci <61233757+MaxAake@users.noreply.github.com> Date: Mon, 15 Sep 2025 16:11:17 +0200 Subject: [PATCH 2/2] wrap browser write error --- packages/bolt-connection/src/channel/browser/browser-channel.js | 2 +- .../lib/bolt-connection/channel/browser/browser-channel.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/bolt-connection/src/channel/browser/browser-channel.js b/packages/bolt-connection/src/channel/browser/browser-channel.js index 4d7fed9e8..1e47b079f 100644 --- a/packages/bolt-connection/src/channel/browser/browser-channel.js +++ b/packages/bolt-connection/src/channel/browser/browser-channel.js @@ -151,7 +151,7 @@ export default class WebSocketChannel { this._handleConnectionError() } else { // Some other error occured - throw error + throw newError('unexpected failure to write.', undefined, error) } } } else { diff --git a/packages/neo4j-driver-deno/lib/bolt-connection/channel/browser/browser-channel.js b/packages/neo4j-driver-deno/lib/bolt-connection/channel/browser/browser-channel.js index 1124d49a0..dd152ff6a 100644 --- a/packages/neo4j-driver-deno/lib/bolt-connection/channel/browser/browser-channel.js +++ b/packages/neo4j-driver-deno/lib/bolt-connection/channel/browser/browser-channel.js @@ -151,7 +151,7 @@ export default class WebSocketChannel { this._handleConnectionError() } else { // Some other error occured - throw error + throw newError('unexpected failure to write.', undefined, error) } } } else {