Skip to content

Remove knownHost config #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

Remove knownHost config #1335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/bolt-connection/src/channel/channel-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ export default class ChannelConfig {
this.encrypted = extractEncrypted(driverConfig)
this.trust = extractTrust(driverConfig)
this.trustedCertificates = extractTrustedCertificates(driverConfig)
this.knownHostsPath = extractKnownHostsPath(driverConfig)
this.connectionErrorCode = connectionErrorCode || SERVICE_UNAVAILABLE
this.connectionTimeout = driverConfig.connectionTimeout
this.clientCertificate = clientCertificate
Expand Down Expand Up @@ -83,7 +82,3 @@ function extractTrust (driverConfig) {
function extractTrustedCertificates (driverConfig) {
return driverConfig.trustedCertificates || []
}

function extractKnownHostsPath (driverConfig) {
return driverConfig.knownHosts || null
}
1 change: 0 additions & 1 deletion packages/core/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ export class Config {
encrypted?: boolean | EncryptionLevel
trust?: TrustStrategy
trustedCertificates?: string[]
knownHosts?: string
fetchSize?: number
maxConnectionPoolSize?: number
maxTransactionRetryTime?: number
Expand Down
5 changes: 0 additions & 5 deletions packages/neo4j-driver-deno/lib/bolt-connection/channel/channel-config.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/neo4j-driver-deno/lib/core/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 0 additions & 14 deletions packages/neo4j-driver/test/internal/channel-config.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,6 @@ describe('#unit ChannelConfig', () => {
expect(config.trustedCertificates).toEqual(trustedCertificates)
})

it('should respect given known hosts', () => {
const knownHostsPath = '~/.neo4j/known_hosts'

const config = new ChannelConfig(null, { knownHosts: knownHostsPath }, '')

expect(config.knownHostsPath).toEqual(knownHostsPath)
})

it('should respect given connection error code', () => {
const connectionErrorCode = 'ConnectionFailed'

Expand All @@ -97,12 +89,6 @@ describe('#unit ChannelConfig', () => {
expect(config.trustedCertificates).toEqual([])
})

it('should have null known hosts path when not configured', () => {
const config = new ChannelConfig(null, {}, '')

expect(config.knownHostsPath).toBeNull()
})

it('should have service unavailable as default error code', () => {
const config = new ChannelConfig(null, {}, '')

Expand Down
1 change: 0 additions & 1 deletion packages/neo4j-driver/test/types/driver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ const config: Config = dummy
const encrypted: undefined | boolean | EncryptionLevel = config.encrypted
const trust: undefined | TrustStrategy = config.trust
const trustedCertificates: undefined | string[] = config.trustedCertificates
const knownHosts: undefined | string = config.knownHosts
const maxTransactionRetryTime: undefined | number =
config.maxTransactionRetryTime
const maxConnectionLifetime: undefined | number = config.maxConnectionLifetime
Expand Down