Fix: Vagrantfile rubocop violations #1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1427 +/- ##
=======================================
Coverage 96.86% 96.86%
=======================================
Files 205 205
Lines 12440 12440
=======================================
Hits 12050 12050
Misses 390 390Continue to review full report at Codecov.
|
Contributor
Author
|
these changes are also included in #1419 |
Contributor
|
👍 Thanks |
jorroll
commented
Sep 23, 2017
| config.vm.network "forwarded_port", guest: 7472, host: 7472, host_ip: "127.0.0.1" | ||
| config.vm.network 'forwarded_port', guest: 7474, host: 9474, host_ip: '127.0.0.1' | ||
| config.vm.network 'forwarded_port', guest: 7473, host: 9473, host_ip: '127.0.0.1' | ||
| config.vm.network 'forwarded_port', guest: 7472, host: 9472, host_ip: '127.0.0.1' |
Contributor
Author
There was a problem hiding this comment.
I should not have committed this host port change
Contributor
There was a problem hiding this comment.
Cool, I just put them back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull introduces/changes:
Pings:
@cheerfulstoic
@subvertallchris