Safekeeper: rename WAL backup to WAL upload (#8146) #10940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oad and wal_upload_partial
…oad in copy_timeline.rs
…keeper.rs, wal_upload_partial and rate_limit
github-actions
bot
added
the
external
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently WAL uploads are referred to as backups in the safekeeper codebase. This is misleading as the segments in remote storage can be the only copy of the data, rather than a backup.
Therefore, it makes sense to rename these as uploads in order to remove the misleading naming.
See #8146 for further context.
Summary of changes