This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
Fix assembly loading on windows headless #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljoonal
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Look at these docs. Nothing in them has a big ol "danger this will just be broken in some cases" label. WTF.
Stack overflow says:
Main difference is that LoadFrom can be redirected to another assembly at a different path but with same identity if it's already loaded. LoadFile just loads exactly what the caller requested.
So I'm guessing that there's some funny things on headless where the neos assembly is actually not loaded from the exe file..?
|
I have no idea. Froox uses LoadFrom to load plugins, and I've tested this on my headed install and it didn't break. So it looks like it's 1.12.1 time. Ugh. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #53.
I don't know why. I don't know how. Send help.
Look at these docs. Nothing in them has a big ol "danger this will just be broken in some cases" label. WTF.
Assembly.LoadFrom
Assembly.LoadFile