TASK: Phpstan match on class dont /** @phpstan-ignore-next-line */

[mhsdesign]

see

neos-development-collection/Neos.ContentRepository.Core/Classes/Feature/NodeAggregateCommandHandler.php

Lines 115 to 119 in 88cb1fd

	/** @phpstan-ignore-next-line */
	return match ($command::class) {
	SetNodeProperties::class => $this->handleSetNodeProperties($command, $contentRepository),
	SetSerializedNodeProperties::class
	=> $this->handleSetSerializedNodeProperties($command, $contentRepository),

where we match on the class, but phpstan doesnt understand that the object is of the matched kind in the match arm, so we /** @phpstan-ignore-next-line */ the code. Which is cruel.

This issue came up again in #4349 (comment)

[mhsdesign]

@grebaldi wrote

I believe that if $destination = $newLocation->destination were established before the match clause, so that we'd actually do:

$destination = $newLocation->destination;
match ($destination::class) {
    /* ... */
};

phpstan would be able to narrow the type of $destination through the match arms. I'm not sure though.

edit, that wouldnt explain the phpstan ignore annotation above, but maybe phpstand got smarter?

[mhsdesign]

A few cases have been cleaned up here: #4455 (comment)

[mhsdesign]

I tried to fix these matches with #4643 but it turns out that there is no easy way around this.

The command handler are a dynamic construct in regards to canHandle and handle. We dont exhaustively match all cases because we dont handle them all and want an exception to be thrown.

One could use generics to tell the command handler in its template that it can only handle those commands and thus narrow the type of the handle method, but we would effectively gain nothing, as we only call the handle once in the command bus where everything is highly dynamic - so static analysis doesnt help.