9.0 Neos.Neos:NodeUri relative uris?

[mhsdesign]

what should happen to relative node uris and baseNodeName

neos-development-collection/Neos.Neos/Classes/Fusion/NodeUriImplementation.php

Lines 109 to 112 in cdce7c8

	public function getBaseNodeName()
	{
	return $this->fusionValue('baseNodeName');
	}

Currently we just removed the whole relative logic, and "baseNodeName" will be unused. :D

And while were at it - baseNodeName was not such a cool idea after all: #2274

[mhsdesign]

Okay i did a little research. Little did i know about neos 8.3 node paths syntax.

Regarding to

neos-development-collection/Neos.Neos/Classes/TYPO3CR/NeosNodeService.php

Line 32 in 140f3bb

public function normalizePath($path, $referencePath = null, $siteNodePath = null)

it seems that its possible to enter following nodepaths in a neos 8.3 Neos.Neos:NodeUri or <neos:uri.node />

• ~/about/us tilde means site relative
• /sites/acmecom/about/us absolute from the root
• ./neos/info relative (or without dotneos/info)
• ../foo/../../bar possibly some kind of traversal see

  neos-development-collection/Neos.ContentRepository/Classes/Domain/Utility/NodePaths.php

  Line 174 in 072186e

  public static function replaceRelativePathElements($path)

not a nodepath but an id will do as well:

• node://30e893c1-caef-0ca5-b53d-e5699bb8e506

---

Neos 9 discourages nodepaths and only supports mandatory simple syntax on the cr side.

• some/relative/path -> see NodePath
• /<Neos.ContentRepository:Root>/my/site (new) see AbsoluteNodePath

custom traversal logic or the magic tilde ~ has to be implemented from the outside.

it seems that the view helpers neos:link.node and neos:uri.node have already been adjusted to allow:

• some/relative/path
• and special ~/some/site/relativepath

In contrast the Neos.Neos:NodeUri awaits to be implemented:

neos-development-collection/Neos.Neos/Classes/Fusion/NodeUriImplementation.php

Lines 132 to 142 in 1801fbb

	/** @todo implement us
	elseif ($node === '~') {
	$nodeAddress = $this->nodeAddressFactory->createFromNode($node);
	$nodeAddress = $nodeAddress->withNodeAggregateId(
	$this->nodeSiteResolvingService->findSiteNodeForNodeAddress($nodeAddress)->getNodeAggregateId()
	);
	} elseif (is_string($node) && substr($node, 0, 7) === 'node://') {
	$nodeAddress = $this->nodeAddressFactory->createFromNode($node);
	$nodeAddress = $nodeAddress->withNodeAggregateId(
	NodeAggregateId::fromString(\mb_substr($node, 7))
	);*/

The question is which are the desired syntax we want to allow.

Additionally we most likely need to update our documentation.

[kitsunet]

I guess the ~ could be implemented as we can have a contextual knowledge about which site is active here? The rest 🤷 I am fine to axe. 🔥

[mhsdesign]

okay so allow

• /<Neos.ContentRepository:Root>/my/site
• some/relative/path
• ~/about/us will be transformed to /<Neos.Neos:Sites>/mysite/about/us

and that handling should be uniformed for those two viewhelpers and fusion in one place. Maybe Neos\Neos\Utility\LegacyNodePathNormalizer which we will also deprecate.