TASK: Mark Node constructor internal #4318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
approved these changes
Jun 9, 2023
|
Copied originally from #4317 While discussing how to stub nodes in unit test in slack: https://neos-project.slack.com/archives/C3MCBK6S2/p1686294507655429 @bwaidelich wrote in slack
Which got me thinking, that the constructor is actually not Also it is true that the constructor is changed over time last change was with: #4102 (which was not considered breaking api wise, even if the constructor changed) |
bwaidelich
added a commit
that referenced
this pull request
Oct 31, 2023
This is a follow-up to #4318 that makes the constructor of the `Node` read model private in favor of a new static `create` constructor. Background: Adding the `@internal` annotation to the constructor marked all promoted properties internal, too. Additionally, a named constructor gives us more options to adjust this class without breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.