Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: migratelegacydata warn if no valid content dimension configuration #4384

Conversation

mhsdesign
Copy link
Member

@grebaldi stumbled upon this while migrating the Neos UI testing distribution. https://neos-project.slack.com/archives/C3MCBK6S2/p1688648280110549

in case you dindt migrate your dimensions first (eg the default repository doesnt have a dimension configuration) but you previously used dimensions in neos 8, then you will face this error:

Failed to find parent node for node with id "f676459d-ca77-44bc-aeea-44114814c279" and dimensions: {"language":"fr"}. The old CR can sometimes have orphaned nodes.

@grebaldi wrote

After running through, I export via ./flow cr:export. In the resulting file, I find only two events: ContentStreamWasCreated and RootNodeAggregateWithNodeWasCreated. Looks to me as if the legacy migration mistook every node of the test site for an orphaned node.

we debugged the NodeDataToEventsProcessor and after some time had the correct guess that we need to first configure the dimensions.

A few hours of debugging can save us 5 minutes of reading the documentation ^^ (well there is no documentation yet also ^^)

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign
Copy link
Member Author

im not sure if this tipp is enough, or we should try to auto migrate the configuration?

@skurfuerst skurfuerst merged commit f4ed836 into 9.0 Jul 7, 2023
@skurfuerst skurfuerst deleted the bugfix/migratelegacydataWarnIfNoValidContentDimensionConfiguration branch July 7, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants