!!! BUGFIX: Actually execute moveSubtreeTags tests and fix moveSubtreeTags

[nezaniel]

Fixup #4993

This now actually asserts stuff when testing moveSubtreeTags, thanks to @mhsdesign for detecting this.

Also, the acutal moveSubtreeTags method is fixed to properly apply tags to the moved node and its descendants

Upgrade instructions

This raises the supported database platforms. Mariadb 10.4 for example will no longer be supported.See #4337

Additionally there are cases where it would make sense to replay the projection to apply this fix:

./flow cr:projectionReplay contentGraph

Review instructions

none

Checklist

• Code follows the PSR-12 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[bwaidelich]

Now I understood the issue. Thanks for fixing this, looks great!

[nezaniel]

As for the failing test: I think the code is right, could you please check the test case @bwaidelich ?

[nezaniel]

Okay, this is a bigger issue as the moveSubtreeTags CTE needs to be rewritten.
We also need more tests for the cases where descendants with explicit tags get moved to a new ancestor with the same tag. That the single test failed was far too much on the luck side for comfort. Converting to draft for now

[nezaniel]

Applied a few final fixes to the moveSubtreeTags CTE and tadaaa: Tests that make assertions and are green

[bwaidelich]

Thanks a lot, +1 by 👁️

[mhsdesign]

Thanks ;) as by reading would smoke my brain, i was trying to test this change against the NeosUi for some visual reference but i cannot come up with a test scenario that fails currently :O ... so this must be an absolute edgecase?

Feel free to merge this with bastian's approval though ^^

[mhsdesign]

Does this require a cr:projectionReplay? Or was this not a bug in beta 9?

[nezaniel]

there are cases where the graph projection needs to be replayed, yes