Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Mark projection as stale after applying an event. #5242

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Sep 11, 2024

At the moment the projection is just marked as stale once per "event set". This raises issues in catchup hooks on publish, as int this cases a set of multiple events get applied.

This change ensures a clean state after each applied event.

@dlubitz dlubitz self-assigned this Sep 11, 2024
@dlubitz dlubitz requested a review from bwaidelich September 11, 2024 14:50
@dlubitz dlubitz requested a review from bwaidelich September 11, 2024 15:05
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense IMO – even with the planned rewrite #5243

Copy link
Member

@skurfuerst skurfuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@skurfuerst skurfuerst merged commit 30ec753 into neos:9.0 Sep 12, 2024
9 checks passed
@dlubitz dlubitz deleted the 90/bugfix/mark-stale branch September 17, 2024 15:42
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Oct 21, 2024
neos-bot pushed a commit to neos/contentrepository-core that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants