Require additional and updated testing packages for the CR test suite #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nezaniel
requested review from
kdambekalns,
bwaidelich,
skurfuerst and
robertlemke
6 tasks
mhsdesign
approved these changes
Aug 23, 2023
| "symfony/css-selector": "^2.0", | ||
| "vimeo/psalm": "~4.9.3", | ||
| "vimeo/psalm": "^5.0", |
There was a problem hiding this comment.
are we sure about this? - i the code compliant?
There was a problem hiding this comment.
Shouldn't be a problem (runs with phpunit 10 locally), but even if this fails for some reason it should be fixed asap in the dev collection
| @@ -40,9 +40,10 @@ | |||
| "neos/setup": "@dev", | |||
| "flowpack/neos-frontendlogin": "@dev", | |||
| "mikey179/vfsstream": "^1.6", | |||
| "phpunit/phpunit": "^9.0", | |||
| "behat/behat": "^3.0", | |||
| "phpunit/phpunit": "^10.0", | |||
There was a problem hiding this comment.
dont we have like code that needs to be adjusted? ^^
dlubitz
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.