Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a migration for people using „sites“ and rewrite this to Neos.Neos:Sites? #24

Closed
mhsdesign opened this issue Jun 17, 2023 · 3 comments

Comments

@mhsdesign
Copy link
Member

We should provide a migration for people using „sites“ and rewrite this to Neos.Neos:Sites

Originally posted by @mhsdesign in neos/neos-development-collection#4339 (comment)

to be discussed in which places this should happen.

most obvious ones are in yaml configurations fx for startingPoints of the reference editor.

i think transforming php automagically might not be trivial, so I would count on manual migration there, but we should still highlight possible places with todo comments

@mhsdesign mhsdesign transferred this issue from neos/neos-development-collection Sep 19, 2023
@dlubitz
Copy link
Contributor

dlubitz commented Sep 29, 2023

@mhsdesign Can we somehow make this more specific?

@mhsdesign
Copy link
Member Author

Hmm maybe this is unmigrateable as nodePaths are discouraged, so everyone using them should revisit this code either way.

old:

/sites/my-site-node/bla

new:

/<Neos.Neos:Sites>/my-site-node/bla

@dlubitz
Copy link
Contributor

dlubitz commented Nov 21, 2024

Can we close this @mhsdesign ?

@mhsdesign mhsdesign closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants